Bug #119920 for Dancer2-Logger-Fluent: pod coverage test fails

Fri Jan 20 01:12:29 2017 SREZIC [...] cpan.org - Ticket created

Subject:

pod coverage test fails

pod-coverage.t test fails: # Failed test 'Pod coverage on Dancer2::Logger::Fluent' # at /usr/perl5.16.3t/lib/site_perl/5.16.3/Test/Pod/Coverage.pm line 133. # Coverage for Dancer2::Logger::Fluent is 66.7%, with 5 naked subroutines: # has_buffer_limit # has_buffer_overflow_handler # has_fluent # has_prefer_integer # has_timeout # Looks like you failed 1 test of 1. t/pod-coverage.t ....... Dubious, test returned 1 (wstat 256, 0x100) Failed 1/1 subtests

Fri Jan 20 14:44:20 2017 ether [...] cpan.org - Correspondence added

On 2017-01-19 22:12:29, SREZIC wrote: Show quoted text

> pod-coverage.t test fails: > > # Failed test 'Pod coverage on Dancer2::Logger::Fluent' > # at /usr/perl5.16.3t/lib/site_perl/5.16.3/Test/Pod/Coverage.pm line 133. > # Coverage for Dancer2::Logger::Fluent is 66.7%, with 5 naked subroutines: > # has_buffer_limit > # has_buffer_overflow_handler > # has_fluent > # has_prefer_integer > # has_timeout > # Looks like you failed 1 test of 1. > t/pod-coverage.t ....... > Dubious, test returned 1 (wstat 256, 0x100) > Failed 1/1 subtests

While this test failure is indeed an issue that should be corrected, please don't allow pod, critic, coverage or kwalitee tests to run for normal user installs, as they make the installation fail unnecessarily when newer versions of the tester module introduces errors that you cannot anticipate. Also spelling tests are dependent on what dictionaries are installed locally, and critic tests use all plugins that are installed, neither of which can be predicted in advance. Either move these tests to xt/, or guard them with: plan skip_all => "These tests are for authors only!" unless $ENV{AUTHOR_TESTING} or $ENV{RELEASE_TESTING};

Fri Jan 20 14:44:20 2017 The RT System itself - Status changed from 'new' to 'open'

Sat Jan 21 02:25:01 2017 ATANCASIS [...] cpan.org - Correspondence added

RT-Send-CC:

ether [...] cpan.org

On Fri Jan 20 14:44:20 2017, ETHER wrote: Show quoted text

> On 2017-01-19 22:12:29, SREZIC wrote:

> > pod-coverage.t test fails: > > > > # Failed test 'Pod coverage on Dancer2::Logger::Fluent' > > # at /usr/perl5.16.3t/lib/site_perl/5.16.3/Test/Pod/Coverage.pm > > line 133. > > # Coverage for Dancer2::Logger::Fluent is 66.7%, with 5 naked > > subroutines: > > # has_buffer_limit > > # has_buffer_overflow_handler > > # has_fluent > > # has_prefer_integer > > # has_timeout > > # Looks like you failed 1 test of 1. > > t/pod-coverage.t ....... > > Dubious, test returned 1 (wstat 256, 0x100) > > Failed 1/1 subtests

> > > While this test failure is indeed an issue that should be corrected, > please don't allow pod, critic, coverage or kwalitee tests to run for > normal user installs, as they make the installation fail unnecessarily > when newer versions of the tester module introduces errors that you > cannot anticipate. Also spelling tests are dependent on what > dictionaries are installed locally, and critic tests use all plugins > that are installed, neither of which can be predicted in advance. > > Either move these tests to xt/, or guard them with: > > plan skip_all => "These tests are for authors only!" unless > $ENV{AUTHOR_TESTING} or $ENV{RELEASE_TESTING};

Thank you so much for pointing this out Slaven, and for the advice, Karen! MUCH appreciated! :) I'll fix this by guarding these tests with for author/release testing only, as adviced. Thanks again! Arnold

Sat Jan 21 07:45:17 2017 ATANCASIS [...] cpan.org - Correspondence added

On Sat Jan 21 02:25:01 2017, ATANCASIS wrote: Show quoted text

> On Fri Jan 20 14:44:20 2017, ETHER wrote:

> > On 2017-01-19 22:12:29, SREZIC wrote:

> > > pod-coverage.t test fails: > > > > > > # Failed test 'Pod coverage on Dancer2::Logger::Fluent' > > > # at /usr/perl5.16.3t/lib/site_perl/5.16.3/Test/Pod/Coverage.pm > > > line 133. > > > # Coverage for Dancer2::Logger::Fluent is 66.7%, with 5 naked > > > subroutines: > > > # has_buffer_limit > > > # has_buffer_overflow_handler > > > # has_fluent > > > # has_prefer_integer > > > # has_timeout > > > # Looks like you failed 1 test of 1. > > > t/pod-coverage.t ....... > > > Dubious, test returned 1 (wstat 256, 0x100) > > > Failed 1/1 subtests

> > > > > > While this test failure is indeed an issue that should be corrected, > > please don't allow pod, critic, coverage or kwalitee tests to run for > > normal user installs, as they make the installation fail > > unnecessarily > > when newer versions of the tester module introduces errors that you > > cannot anticipate. Also spelling tests are dependent on what > > dictionaries are installed locally, and critic tests use all plugins > > that are installed, neither of which can be predicted in advance. > > > > Either move these tests to xt/, or guard them with: > > > > plan skip_all => "These tests are for authors only!" unless > > $ENV{AUTHOR_TESTING} or $ENV{RELEASE_TESTING};

> > Thank you so much for pointing this out Slaven, and for the advice, > Karen! MUCH appreciated! :) > > I'll fix this by guarding these tests with for author/release testing > only, as adviced. > > Thanks again! > Arnold

Sat Jan 21 07:45:23 2017 ATANCASIS [...] cpan.org - Status changed from 'open' to 'resolved'

Sat Jan 21 07:45:23 2017 ATANCASIS [...] cpan.org - Fixed in 0.05 added