Skip Menu |

This queue is for tickets about the Net-STOMP-Client CPAN distribution.

Report information
The Basics
Id: 119869
Status: resolved
Priority: 0/
Queue: Net-STOMP-Client
People
Owner: LCONS [...] cpan.org
Requestors: TJC [...] cpan.org
Cc:
AdminCc:
Bug Information
Severity: (no value)
Broken in: 2.2
Fixed in: 2.3

History Show all quoted text
  Sun Jan 15 19:18:25 2017 TJC [...] cpan.org - Ticket created
Subject: failover regex does not match domain names including underscore character
In Net-STOMP-Client-Connection.pm, the regex used to match failover()-type URIs will fail to match if the domain name includes an underscore character.
  Mon Jan 16 02:15:38 2017 LCONS [...] cpan.org - Correspondence added
Net-STOMP-Client complies to RFC-952 that specifies that: A "name" (Net, Host, Gateway, or Domain name) is a text string up to 24 characters drawn from the alphabet (A-Z), digits (0-9), minus sign (-), and period (.). Underscores should not appear in domain names.
  Mon Jan 16 02:15:39 2017 The RT System itself - Status changed from 'new' to 'open'
  Mon Jan 16 02:20:27 2017 TJC [...] cpan.org - Correspondence added
Back when the original standard was built, sure, but I've seen plenty of underscores turn up in domain names in recent years -- even as subdomains off google's base domain name. Essentially -- it'd be good if Net-STOMP-Client was flexible and didn't try and enforce that standard. How's the saying go? "Be conservative in what you send, be liberal in what you accept"
  Mon Jan 16 02:22:50 2017 TJC [...] cpan.org - Correspondence added
See also the URI specification, which would seem to be the more correct spec to apply to the MQ URIs: https://tools.ietf.org/html/rfc3986#section-2
  Mon Jan 16 03:13:44 2017 LCONS [...] cpan.org - Taken
  Mon Jan 16 03:14:42 2017 LCONS [...] cpan.org - Correspondence added
Fair enough. I've modified the sources so the next released version will allow underscores.
  Mon Jan 16 04:08:29 2017 TJC [...] cpan.org - Correspondence added
Thanks, I appreciate your understanding.
  Wed Feb 01 02:21:40 2017 LCONS [...] cpan.org - Fixed in 2.3 added
  Wed Feb 01 02:22:24 2017 LCONS [...] cpan.org - Correspondence added
Fixed in the newly released 2.3.
  Wed Feb 01 02:22:25 2017 LCONS [...] cpan.org - Status changed from 'open' to 'resolved'