Skip Menu |

This queue is for tickets about the Data-Table-Text CPAN distribution.

Report information
The Basics
Id: 119832
Status: resolved
Priority: 0/
Queue: Data-Table-Text
People
Owner: Nobody in particular
Requestors: ANDK [...] cpan.org
Cc:
AdminCc:
Bug Information
Severity: (no value)
Broken in: 2017.109
Fixed in: (no value)

History Show all quoted text
  Thu Jan 12 07:39:46 2017 ANDK [...] cpan.org - Ticket created
Subject: [PATCH] Fails on perl <= 5.18.4
The bug is actually in the newer perls, they do not issue a warning where a warning always was due but during the transition from 5.18 to 5.20 it got lost. This has been reported to perlbug as https://rt.perl.org/Ticket/Display.html?id=130546 The warning can be averted with the attached patch, basically just replace '@' with '$' in the following line: delete @parms{$_} for keys %$permitted; HTH&&Thanks,
Subject: patch-DTT-2017.109.diff
--- lib/Data/Table/Text.pm~ 2017-01-12 12:33:02.196992356 +0000 +++ lib/Data/Table/Text.pm 2017-01-12 12:33:26.624904891 +0000 @@ -300,7 +300,7 @@ sub checkKeys($$) {my ($test, $permitted) = @_; # The hash to test, the permitted keys and their meanings my %parms = %$test; - delete @parms{$_} for keys %$permitted; + delete $parms{$_} for keys %$permitted; return '' unless keys %parms; # Success - all the keys in the test hash are permitted confess join "\n", # Failure - explain what went wrong
  Thu Jan 12 09:43:24 2017 prbrenan [...] cpan.org - Correspondence added
Fixed -thank you very much for your helpful patch!
  Thu Jan 12 09:43:24 2017 The RT System itself - Status changed from 'new' to 'open'
  Thu Jan 12 09:43:24 2017 prbrenan [...] cpan.org - Status changed from 'open' to 'resolved'
  Thu Jan 12 09:45:44 2017 philiprbrenan [...] gmail.com - Correspondence added
Subject: Re: [rt.cpan.org #119832] [PATCH] Fails on perl <= 5.18.4
Date: Thu, 12 Jan 2017 14:44:57 +0000
To: bug-Data-Table-Text [...] rt.cpan.org
From: Philip R Brenan <philiprbrenan [...] gmail.com>
Fixed - your helpful patch much appreciated! On Thu, Jan 12, 2017 at 12:39 PM, Andreas Koenig via RT < bug-Data-Table-Text@rt.cpan.org> wrote: Show quoted text
> Thu Jan 12 07:39:46 2017: Request 119832 was acted upon. > Transaction: Ticket created by ANDK > Queue: Data-Table-Text > Subject: [PATCH] Fails on perl <= 5.18.4 > Broken in: 2017.109 > Severity: (no value) > Owner: Nobody > Requestors: ANDK@cpan.org > Status: new > Ticket <URL: https://rt.cpan.org/Ticket/Display.html?id=119832 > > > > The bug is actually in the newer perls, they do not issue a warning where > a warning always was due but during the transition from 5.18 to 5.20 it got > lost. This has been reported to perlbug as https://rt.perl.org/Ticket/ > Display.html?id=130546 > > The warning can be averted with the attached patch, basically just replace > '@' with '$' in the following line: > > delete @parms{$_} for keys %$permitted; > > HTH&&Thanks, > > --- lib/Data/Table/Text.pm~ 2017-01-12 12:33:02.196992356 +0000 > +++ lib/Data/Table/Text.pm 2017-01-12 12:33:26.624904891 +0000 > @@ -300,7 +300,7 @@ > sub checkKeys($$) > {my ($test, $permitted) = @_; > # The hash to test, the permitted keys and their meanings > my %parms = %$test; > - delete @parms{$_} for keys %$permitted; > + delete $parms{$_} for keys %$permitted; > return '' unless keys %parms; > # Success - all the keys in the test hash are permitted > > confess join "\n", > # Failure - explain what went wrong > >
-- Thanks, Phil <http://www.appaapps.com/cgi-bin/DashBoard/allStarts.pl> Philip R Brenan <http://www.appaapps.com/cgi-bin/DashBoard/allStarts.pl>