Skip Menu |

This queue is for tickets about the Parse-Dia-SQL CPAN distribution.

Report information
The Basics
Id: 119725
Status: resolved
Priority: 0/
Queue: Parse-Dia-SQL

People
Owner: Nobody in particular
Requestors: SREZIC [...] cpan.org
Cc:
AdminCc:

Bug Information
Severity: (no value)
Broken in: 0.27
Fixed in: (no value)



Subject: Tests fail (with newest HTML::Lint?)
My smokers started to report test failures: ... # Failed test 'Failed test using HTML::Lint - invalid HTML' # at t/691-output-html-get-sql.t line 52. # HTML-Lint: $VAR1 = bless( { # '_column' => 74, # '_errcode' => 'api-eof-not-called', # '_line' => 150, # '_errtext' => 'The eof() method has not been called on this file.', # '_type' => 1, # '_file' => undef # }, 'HTML::Lint::Error' ); # HTML-Lint: $VAR1 = bless( { # '_line' => 150, # '_errtext' => 'The eof() method has not been called on this file.', # '_type' => 1, # '_file' => undef, # '_column' => 74, # '_errcode' => 'api-eof-not-called' # }, 'HTML::Lint::Error' ); # Looks like you failed 1 test of 8. t/691-output-html-get-sql.t ................................. Dubious, test returned 1 (wstat 256, 0x100) Failed 1/8 subtests ... Looking at the Changes file of HTML-Lint-2.26, it seems that this change is responsible for the problem: https://metacpan.org/source/PETDANCE/HTML-Lint-2.26/Changes#L30
On 2017-01-06 02:39:13, SREZIC wrote: Show quoted text
> My smokers started to report test failures: > > ... > # Failed test 'Failed test using HTML::Lint - invalid HTML' > # at t/691-output-html-get-sql.t line 52. > # HTML-Lint: $VAR1 = bless( { > # '_column' => 74, > # '_errcode' => 'api-eof-not-called', > # '_line' => 150, > # '_errtext' => 'The eof() method has not been called > on this file.', > # '_type' => 1, > # '_file' => undef > # }, 'HTML::Lint::Error' ); > # HTML-Lint: $VAR1 = bless( { > # '_line' => 150, > # '_errtext' => 'The eof() method has not been called > on this file.', > # '_type' => 1, > # '_file' => undef, > # '_column' => 74, > # '_errcode' => 'api-eof-not-called' > # }, 'HTML::Lint::Error' ); > # Looks like you failed 1 test of 8. > t/691-output-html-get-sql.t ................................. > Dubious, test returned 1 (wstat 256, 0x100) > Failed 1/8 subtests > ... > > Looking at the Changes file of HTML-Lint-2.26, it seems that this > change is responsible for the problem: > https://metacpan.org/source/PETDANCE/HTML-Lint-2.26/Changes#L30
Here's statistical analysis --- it also suggests that HTML::Lint 2.26 is causing the problem (negative theta means "bad"): **************************************************************** Regression 'mod:HTML::Lint' **************************************************************** Name Theta StdErr T-stat [0='const'] 1.0000 0.0000 218573749526057472.00 [1='eq_2.22'] 0.0000 0.0000 9.12 [2='eq_2.24'] 0.0000 0.0000 0.00 [3='eq_2.26'] -1.0000 0.0000 -116832583495578608.00 R^2= 1.000, N= 55, K= 4 ****************************************************************
On Fri Jan 06 02:39:13 2017, SREZIC wrote: Show quoted text
> Looking at the Changes file of HTML-Lint-2.26, it seems that this > change is responsible for the problem: > https://metacpan.org/source/PETDANCE/HTML-Lint-2.26/Changes#L30
Thank you for your report. HTML-Lint-2.26 requires "$lint->eof();" which is added to Parse-Dia-SQL-0.28. Best regards Andreas