Skip Menu |

This queue is for tickets about the Class-Trigger CPAN distribution.

Report information
The Basics
Id: 119707
Status: open
Priority: 0/
Queue: Class-Trigger

People
Owner: Nobody in particular
Requestors: ilmari+cpan [...] ilmari.org
Cc:
AdminCc:

Bug Information
Severity: (no value)
Broken in: (no value)
Fixed in: (no value)



Subject: Bundles extraneous modules in inc/
Building Class::Trigger on perl 5.20.0 or newere gives a lot of "Possible precedence issue with control flow operator" warnings from the bundled old version of Test::Builder, pulled in by either the 'use_test_base' directive. It turns out neither Test::Base nor IO::WrapTie is actually used, and the Test::More version requirement is satisfied by core since well before the 5.8.1 requirement Module::Install imposes. If the goal is to have no non-core requirements, IO::Scalar could be eliminated by using open to a reference instead, which is supported since 5.8.0. Applying the following patch and rebuilding the dist gets rid of the spurious includes: $ git diff --cached Makefile.PL diff --git a/Makefile.PL b/Makefile.PL index b014cf3..594dd0a 100644 --- a/Makefile.PL +++ b/Makefile.PL @@ -5,7 +5,4 @@ all_from 'lib/Class/Trigger.pm'; tests 't/*.t t/*/*.t t/*/*/*.t t/*/*/*/*.t'; test_requires 'Test::More' => 0.32; test_requires 'IO::Scalar'; -test_requires 'IO::WrapTie'; -use_test_base; -auto_include; WriteAll;
On Thu Jan 05 07:17:55 2017, ilmari wrote: Show quoted text
> Building Class::Trigger on perl 5.20.0 or newere gives a lot of > "Possible precedence issue with control flow operator" warnings from > the bundled old version of Test::Builder, pulled in by either the > 'use_test_base' directive. It turns out neither Test::Base nor > IO::WrapTie is actually used, and the Test::More version requirement > is satisfied by core since well before the 5.8.1 requirement > Module::Install imposes.
See a fork at https://github.com/timlegge/Class-Trigger that appears to fix the issue. I have notified the author...