Bug #119534 for MooseX-Types: Migration to Sub::Defer incomplete

Wed Dec 28 03:23:02 2016 ribasushi [...] leporine.io - Ticket created

Subject:

Migration to Sub::Defer incomplete

See attached log of steps to reproduce

Subject:

mxt_wtf.txt

rabbit@Ahasver:~$ cpanm MooseX::Types@0.48 ! Finding MooseX::Types on cpanmetadb failed. --> Working on MooseX::Types Fetching http://www.cpan.org/authors/id/E/ET/ETHER/MooseX-Types-0.48.tar.gz ... OK Configuring MooseX-Types-0.48 ... OK Building and testing MooseX-Types-0.48 ... OK Successfully installed MooseX-Types-0.48 (downgraded from 0.49) 1 distribution installed rabbit@Ahasver:~$ perl -MSub::Defer -MMooseX::Types::LoadableClass -e 'Sub::Defer::undefer_all(); warn "a-ok"' a-ok at -e line 1. rabbit@Ahasver:~$ cpanm MooseX::Types@0.49 ! Finding MooseX::Types on cpanmetadb failed. --> Working on MooseX::Types Fetching http://www.cpan.org/authors/id/E/ET/ETHER/MooseX-Types-0.49.tar.gz ... OK Configuring MooseX-Types-0.49 ... OK Building and testing MooseX-Types-0.49 ... OK Successfully installed MooseX-Types-0.49 (upgraded from 0.48) 1 distribution installed rabbit@Ahasver:~$ perl -MSub::Defer -MMooseX::Types::LoadableClass -e 'Sub::Defer::undefer_all(); warn "a-ok"' MooseX::Types::__ANON__(): Unable to find type 'ClassName' in library 'MooseX::Types::LoadableClass' at /home/rabbit/perl5/perlbrew/perls/5.16.2/lib/site_perl/5.16.2/Sub/Defer.pm line 55

Thu Jan 26 22:35:23 2017 DROLSKY [...] cpan.org - Correspondence added

RT-Send-CC:

ether [...] cpan.org

I think this has something to do with this line - https://metacpan.org/source/ETHER/MooseX-Types-LoadableClass-0.014/lib/MooseX/Types/LoadableClass.pm#L36 I'm not really sure what's going on here. Ether, any thoughts?

Thu Jan 26 22:35:24 2017 The RT System itself - Status changed from 'new' to 'open'

Mon Feb 06 21:02:32 2017 ANDK [...] cpan.org - Correspondence added

Probably same thing: tests failing for DBIx::Class https://rt.cpan.org/Ticket/Display.html?id=120129

Fri Jun 02 17:48:22 2017 OSCHWALD [...] cpan.org - Correspondence added

On Thu Jan 26 22:35:23 2017, DROLSKY wrote: Show quoted text

> I think this has something to do with this line - > https://metacpan.org/source/ETHER/MooseX-Types-LoadableClass- > 0.014/lib/MooseX/Types/LoadableClass.pm#L36 > > I'm not really sure what's going on here. Ether, any thoughts?

I think this is a legitimate bug in MooseX::Types::LoadableClass. I opened a PR here: https://github.com/moose/MooseX-Types-LoadableClass/pull/3 We could work around this issue in MooseX::Types by moving the croak into the inner subroutine so that it only croaks if the type is actually used. If this sounds ok, I'd be happy to make a PR based on Dave's last PR. Greg

Fri Jun 02 18:06:58 2017 OSCHWALD [...] cpan.org - Correspondence added

See https://github.com/moose/MooseX-Types/pull/7