Skip Menu |

This queue is for tickets about the MooseX-Role-Tempdir CPAN distribution.

Report information
The Basics
Id: 119368
Status: resolved
Priority: 0/
Queue: MooseX-Role-Tempdir
People
Owner: Nobody in particular
Requestors: ppisar [...] redhat.com
Cc:
AdminCc:
Bug Information
Severity: (no value)
Broken in: 0.100
Fixed in: 0.101

History Show all quoted text
  Thu Dec 22 08:03:30 2016 ppisar [...] redhat.com - Ticket created
Subject: "ok then\n" on stdout
The 0.100 started to print "ok then\n" to standard output. It breaks TAP parsers if MooseX::Role::Tempdir is used in tests. See <https://github.com/yanick/git-cpan-patch/issues/33>. I think you forgot to remove a debugging code from lib/MooseX/Role/Tempdir.pm:47 before a release.
  Thu Dec 22 08:12:54 2016 ppisar [...] redhat.com - Correspondence added
From: ppisar [...] redhat.com
Dne Čt 22.pro.2016 08:03:30, ppisar napsal(a): Show quoted text
> I think you forgot to remove a debugging code from > lib/MooseX/Role/Tempdir.pm:47 before a release.
Fix is atteched.
Subject: MooseX-Role-Tempdir-0.100-Remove-a-stray-debugging-code.patch
From 244b0377a9d8421b60e1fdb314ce847e39480236 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Petr=20P=C3=ADsa=C5=99?= <ppisar@redhat.com> Date: Thu, 22 Dec 2016 14:05:28 +0100 Subject: [PATCH] Remove a stray debugging code MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit There was a stray debugging code that interfered with TAP. CPAN RT#119368 Signed-off-by: Petr Písař <ppisar@redhat.com> --- lib/MooseX/Role/Tempdir.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/MooseX/Role/Tempdir.pm b/lib/MooseX/Role/Tempdir.pm index 7af2bcc..2c3202a 100644 --- a/lib/MooseX/Role/Tempdir.pm +++ b/lib/MooseX/Role/Tempdir.pm @@ -44,7 +44,7 @@ role { ) } } - print "ok then\n"; + #print "ok then\n"; #my $p = shift; #my $opts = $p->tmpdir_opts(); #for my $dir (@{$p->dirs()}) { -- 2.7.4
  Fri Dec 21 02:26:06 2018 IAMB [...] cpan.org - Correspondence added
On Thu Dec 22 08:03:30 2016, ppisar wrote: Show quoted text
> The 0.100 started to print "ok then\n" to standard output. It breaks > TAP parsers if MooseX::Role::Tempdir is used in tests. See > <https://github.com/yanick/git-cpan-patch/issues/33>. > > I think you forgot to remove a debugging code from > lib/MooseX/Role/Tempdir.pm:47 before a release.
woof. i never got a notification of this issue being opened, and i've never used rt before (i assumed it would email me). thank you very much for taking the time to report this issue and send a fix. it looks like you've worked around the problem yourself, but i will push a fix anyway. my apologies for the *multiple year* delay.
  Fri Dec 21 02:26:07 2018 The RT System itself - Status changed from 'new' to 'open'
  Fri Dec 21 15:06:11 2018 IAMB [...] cpan.org - Correspondence added
fixed in latest
  Fri Dec 21 15:06:11 2018 IAMB [...] cpan.org - Status changed from 'open' to 'resolved'
  Fri Dec 21 15:06:11 2018 IAMB [...] cpan.org - Fixed in 0.101 added