| Subject: | libform, libmenu, and libpanel detection broken (1.11) |
Hello,
In Curses-1.11/Makefile.PL a few configuration variables (namely $panel_libs,
$menu_libs, and $form_libs) are now set to empty string by default, but later
still checked for being defined. This breaks the code responsible for linker
arguments (and consequently, test.syms fails to detect libform, libmenu, and
libpanel functions).
$ cd Curses-1.10
$ perl Makefile.PL PANELS MENUS FORMS &>/dev/null
$ grep 'LIBS =>' Makefile
# LIBS => [q[-lpanel -lmenu -lform -lncurses]]
$ cd ../Curses-1.11
$ perl Makefile.PL PANELS MENUS FORMS &>/dev/null
$ grep 'LIBS =>' Makefile
# LIBS => [q[-lncurses]]
$
Here is a patch.
--
Alexey Tourbin
ALT Linux Team
--- Curses-1.11/Makefile.PL- 2005-03-12 19:35:45 +0000
+++ Curses-1.11/Makefile.PL 2005-03-17 12:15:40 +0000
@@ -303,7 +303,7 @@ if (not -e "c-config.h") {
# Major cheese alert. Any -L for the curses library is probably
# also needed for the panels library.
#
-if ($panels and not defined $panel_libs) {
+if ($panels and not $panel_libs) {
while ($libs =~ m!(-L\S+)!g) {
$panel_libs .= $1;
}
@@ -313,7 +313,7 @@ if ($panels and not defined $panel_libs)
# More major cheese alert. Any -L for the curses library is probably
# also needed for the menus library.
#
-if ($menus and not defined $menu_libs) {
+if ($menus and not $menu_libs) {
while ($libs =~ m!(-L\S+)!g) {
$menu_libs .= $1;
}
@@ -323,7 +323,7 @@ if ($menus and not defined $menu_libs) {
# More major cheese alert. Any -L for the curses library is probably
# also needed for the forms library.
#
-if ($forms and not defined $form_libs) {
+if ($forms and not $form_libs) {
while ($libs =~ m!(-L\S+)!g) {
$form_libs .= $1;
}