Bug #119119 for Slay-Maker: Useless variable

Sat Dec 03 14:10:50 2016 SREZIC [...] cpan.org - Ticket created

Subject:

Useless variable

The variable $cmd in https://metacpan.org/source/NODINE/Slay-Maker-0.08/lib/Slay/MakerRule.pm#L416 is not used anywhere, and probably could be dropped. I think the line before can also be dropped, as the match result is also not used.

Mon Dec 05 18:10:23 2016 nodine [...] cpan.org - Taken

Mon Dec 05 18:13:08 2016 nodine [...] cpan.org - Correspondence added

I agree. Both the variable and the search preceding it are useless. Unfortunately, I have switched jobs since I was maintaining this module and no longer have my development environment. I am also no longer using this module. If you like, I can make you a co-maintainer and then you'll be free to make whatever improvements you see fit. --Mark

Mon Dec 05 18:13:08 2016 The RT System itself - Status changed from 'new' to 'open'

Tue Dec 06 01:19:44 2016 SREZIC [...] cpan.org - Correspondence added

On 2016-12-05 18:13:08, NODINE wrote: Show quoted text

> I agree. Both the variable and the search preceding it are useless. > > Unfortunately, I have switched jobs since I was maintaining this > module and no longer have my development environment. I am also no > longer using this module. If you like, I can make you a co-maintainer > and then you'll be free to make whatever improvements you see fit. >

I would be glad to get co-maintainership for this module and for Slay::Makefile (e.g. to fix https://rt.cpan.org/Ticket/Display.html?id=75383 ). My PAUSE id is SREZIC. Regards, Slaven

Thu Dec 08 10:19:07 2016 barries1 [...] gmail.com - Correspondence added

Subject:	Re: [rt.cpan.org #119119] Useless variable
Date:	Thu, 8 Dec 2016 10:18:44 -0500
To:	bug-Slay-Maker [...] rt.cpan.org
From:	Barrie Slaymaker <barries1 [...] gmail.com>

Wow, Slaven, thanks for picking this up! - Barrie On 12/6/2016 1:19 AM, Slaven_Rezic via RT wrote: Show quoted text

> Queue: Slay-Maker > Ticket <URL: https://rt.cpan.org/Ticket/Display.html?id=119119 > > > On 2016-12-05 18:13:08, NODINE wrote:

>> I agree. Both the variable and the search preceding it are useless. >> >> Unfortunately, I have switched jobs since I was maintaining this >> module and no longer have my development environment. I am also no >> longer using this module. If you like, I can make you a co-maintainer >> and then you'll be free to make whatever improvements you see fit. >>

> I would be glad to get co-maintainership for this module and for Slay::Makefile (e.g. to fix https://rt.cpan.org/Ticket/Display.html?id=75383 ). My PAUSE id is SREZIC. > > Regards, > Slaven

Thu Dec 08 18:21:44 2016 nodine [...] cpan.org - Correspondence added

I agree with Barrie. Thank you for your efforts, Slaven. I've added you as a co-maintainer to Slay::Makefile and Slay::Makefile::Eval. Barrie will have to add you as co-maintainer to Slay::Maker since I'm only a co-maintainer myself. --Mark