Skip Menu |

Preferred bug tracker

Please visit the preferred bug tracker to report your issue.

This queue is for tickets about the URI-Find CPAN distribution.

Report information
The Basics
Id: 11906
Status: resolved
Priority: 0/
Queue: URI-Find

People
Owner: Nobody in particular
Requestors: cnandor [...] cpan.org
Cc:
AdminCc:

Bug Information
Severity: Important
Broken in: 0.14
Fixed in: (no value)



Subject: Reset strict()
The find() method sets URI::URL::strict(1), but doesn't set it back. Callers that depend on a different value for strict are foiled. As strict() returns old value, the fix is a simple save-and-restore. Patch enclosed.
--- Find.pm.orig Mon Oct 11 07:23:26 2004 +++ Find.pm Wed Mar 16 09:02:28 2005 @@ -101,7 +101,7 @@ my $urlsfound = 0; # Don't assume http. - URI::URL::strict(1); + my $strict = URI::URL::strict(1); # Yes, evil. Basically, look for something vaguely resembling a URL, # then hand it off to URI::URL for examination. If it passes, throw @@ -134,6 +134,8 @@ $self->recruft($orig_match); } }eg; + + URI::URL::strict($strict); return $urlsfound; }
To: bug-URI-Find [...] rt.cpan.org
From: Roderick Schertler <roderick [...] argon.org>
Subject: Re: [cpan #11906] Reset strict()
Date: Tue, 22 Mar 2005 11:12:46 -0500
RT-Send-Cc:
On Wed, 16 Mar 2005 12:06:24 -0500 (EST), "Chris_Nandor via RT" <bug-URI-Find@rt.cpan.org> said: Show quoted text
> > The find() method sets URI::URL::strict(1), but doesn't set it back.
Thanks, this is fixed in version 0.15, just uploaded. -- Roderick Schertler roderick@argon.org