Bug #119013 for Term-Screen: bugreport Term::Screen::getch()

Mon Nov 28 12:09:23 2016 ruittenb [...] gmail.com - Ticket created

Subject:	bugreport Term::Screen::getch()
Date:	Mon, 28 Nov 2016 18:09:12 +0100
To:	bug-Term-Screen [...] rt.cpan.org
From:	René Uittenbogaard <ruittenb [...] gmail.com>

Dear sir, I believe I found a bug in your module Term::Screen. When Term::Screen::getch() encounters a sequence of keys which looks like an escape sequence, but the sequence is not recognized, then the characters read up to that point are placed back on the wrong end of the input buffer. It is my impression that line 514: $this->{IN} = CORE::reverse($partial_fn_str) . $this->{IN}; should be replaced with: $this->{IN} = $this->{IN} . CORE::reverse($partial_fn_str); Please view the provided attachment for reproducing the bug. Thanks in advance, René Uittenbogaard

Message body is not shown because sender requested not to inline it.

Thu Dec 01 02:20:10 2016 jonathan.stowe [...] gmail.com - Correspondence added

Subject:	Re: [rt.cpan.org #119013] bugreport Term::Screen::getch()
Date:	Thu, 01 Dec 2016 07:19:42 +0000
To:	bug-Term-Screen [...] rt.cpan.org
From:	Jonathan Stowe <jonathan.stowe [...] gmail.com>

Hi, I'm going to track this one on github as it is easier for me https://gi thub.com/jonathanstowe/Term-Screen/issues/2 Thanks for the report. On Mon, 2016-11-28 at 12:09 -0500, René Uittenbogaard via RT wrote: Show quoted text

> Mon Nov 28 12:09:23 2016: Request 119013 was acted upon. > Transaction: Ticket created by ruittenb@gmail.com > Queue: Term-Screen > Subject: bugreport Term::Screen::getch() > Broken in: (no value) > Severity: (no value) > Owner: Nobody > Requestors: ruittenb@gmail.com > Status: new > Ticket <URL: https://rt.cpan.org/Ticket/Display.html?id=119013 > > > > Dear sir, > > I believe I found a bug in your module Term::Screen. > > When Term::Screen::getch() encounters a sequence of keys which looks > like an escape sequence, but the sequence is not recognized, then the > characters read up to that point are placed back on the wrong end of > the input buffer. > > It is my impression that line 514: > $this->{IN} = CORE::reverse($partial_fn_str) . $this-

> >{IN};

> should be replaced with: > $this->{IN} = $this->{IN} . > CORE::reverse($partial_fn_str); > > Please view the provided attachment for reproducing the bug. > > Thanks in advance, > > René Uittenbogaard >

Thu Dec 01 02:20:11 2016 The RT System itself - Status changed from 'new' to 'open'

Sun Dec 04 15:18:27 2016 jns [...] gellyfish.co.uk - Correspondence added

I've released 1.06 which has your suggested fix

Sun Dec 04 15:18:28 2016 jns [...] gellyfish.co.uk - Status changed from 'open' to 'resolved'

Sun Dec 04 15:18:28 2016 jns [...] gellyfish.co.uk - Taken