Bug #119001 for Config-IniFiles: [PATCH] Correct some typographical and grammatical errors.

Sun Nov 27 12:38:42 2016 roam [...] ringlet.net - Ticket created

From:	roam [...] ringlet.net
Subject:	[PATCH] Correct some typographical and grammatical errors.

Hi, Thanks for taking over and maintaining Config-IniFiles! What do you think about the attached patch that we have just added to the Debian packaging of this module? Description: Correct some typographical and grammatical errors. Author: Peter Pentchev <roam@ringlet.net> Last-Update: 2016-11-27 The patch is tracked in our Git repository at https://anonscm.debian.org/cgit/pkg-perl/packages/libconfig-inifiles-perl.git/plain/debian/patches/typos.patch Thanks for considering, Peter Pentchev, Debian Perl Group

Sun Nov 27 12:38:50 2016 roam [...] ringlet.net - Correspondence added

Here's the patch.

Message body is not shown because sender requested not to inline it.

Sun Nov 27 12:38:50 2016 The RT System itself - Status changed from 'new' to 'open'

Mon Nov 28 09:27:16 2016 SHLOMIF [...] cpan.org - Correspondence added

On Sun Nov 27 12:38:50 2016, ROAM wrote: Show quoted text

> Here's the patch.

Thanks! However, the patch does not apply cleanly to the current git master version at https://github.com/shlomif/perl-Config-IniFiles . (I tried both "git apply" and "patch -p1".) Can you please redo it and send me a new patch or pull-request? -- Shlomi

Tue Nov 29 04:58:13 2016 ROAM [...] cpan.org - Correspondence added

Subject:	Re: [rt.cpan.org #119001] [PATCH] Correct some typographical and grammatical errors.
Date:	Tue, 29 Nov 2016 11:57:52 +0200
To:	Shlomi Fish via RT <bug-Config-IniFiles [...] rt.cpan.org>
From:	Peter Pentchev <roam [...] cpan.org>

On Mon, Nov 28, 2016 at 09:27:27AM -0500, Shlomi Fish via RT wrote: Show quoted text

> <URL: https://rt.cpan.org/Ticket/Display.html?id=119001 > > > On Sun Nov 27 12:38:50 2016, ROAM wrote:

> > Here's the patch.

> > Thanks! However, the patch does not apply cleanly to the current git master version at https://github.com/shlomif/perl-Config-IniFiles . (I tried both "git apply" and "patch -p1".) Can you please redo it and send me a new patch or pull-request?

Right, it was made against the 2.93 release; I was not aware of the (as yet unannounced, it seems :)) move to GitHub. Well, I guess you've already seen https://github.com/shlomif/perl-Config-IniFiles/pull/1 so I'm just leaving a link to it in this bug report, too. G'luck, Peter -- Peter Pentchev roam@ringlet.net roam@FreeBSD.org pp@storpool.com PGP key: http://people.FreeBSD.org/~roam/roam.key.asc Key fingerprint 2EE7 A7A5 17FC 124C F115 C354 651E EFB0 2527 DF13

Download signature.asc
application/pgp-signature 833b

Message body not shown because it is not plain text.

Tue Nov 29 12:41:03 2016 SHLOMIF [...] cpan.org - Correspondence added

Hi Peter! On Tue Nov 29 04:58:13 2016, ROAM@cpan.org wrote: Show quoted text

> On Mon, Nov 28, 2016 at 09:27:27AM -0500, Shlomi Fish via RT wrote:

> > <URL: https://rt.cpan.org/Ticket/Display.html?id=119001 > > > > > On Sun Nov 27 12:38:50 2016, ROAM wrote:

> > > Here's the patch.

> > > > Thanks! However, the patch does not apply cleanly to the current git > > master version at https://github.com/shlomif/perl-Config-IniFiles . > > (I tried both "git apply" and "patch -p1".) Can you please redo it > > and send me a new patch or pull-request?

> > Right, it was made against the 2.93 release; I was not aware of > the (as yet unannounced, it seems :)) move to GitHub. > > Well, I guess you've already seen > https://github.com/shlomif/perl-Config-IniFiles/pull/1 so I'm just > leaving a link to it in this bug report, too. >

I did not see it when I read that text due to the way my email is organised. Anyway, I merged the pull-request with the updated patch and made a new release - 2.94. Thanks for the patch! Closing this bug as fixed. Show quoted text

> G'luck, > Peter

Tue Nov 29 12:41:09 2016 SHLOMIF [...] cpan.org - Status changed from 'open' to 'resolved'