Skip Menu |

This queue is for tickets about the Module-Install CPAN distribution.

Report information
The Basics
Id: 118958
Status: open
Priority: 0/
Queue: Module-Install
People
Owner: ether [...] cpan.org
Requestors: RSCHUPP [...] cpan.org
Cc:
AdminCc:
Bug Information
Severity: (no value)
Broken in: (no value)
Fixed in: (no value)

History Show all quoted text
  Fri Nov 25 08:34:23 2016 RSCHUPP [...] cpan.org - Ticket created
Subject: Module::Install::PAR is broken when @INC doesn't include "."
Breaks the "par_base" directive, patch attached. Cheers, Roderich
Subject: no-dot-in-INC.patch
--- a/lib/Module/Install/PAR.pm +++ b/lib/Module/Install/PAR.pm @@ -49,7 +49,7 @@ sub par_base { # --- $class section: all :: -\t\$(NOECHO) $perl "-M$inc_class" -e "extract_par(q($file))" +\t\$(NOECHO) $perl -I. "-M$inc_class" -e "extract_par(q($file))" END_MAKEFILE @@ -57,7 +57,7 @@ END_MAKEFILE # --- $class section: $file: all test -\t\$(NOECHO) \$(PERL) "-M$inc_class" -e "make_par(q($file))" +\t\$(NOECHO) \$(PERL) -I. "-M$inc_class" -e "make_par(q($file))" par :: $file \t\$(NOECHO) \$(NOOP)
  Fri Nov 25 14:10:57 2016 ether [...] cpan.org - Taken
  Tue Apr 04 20:31:21 2017 ether [...] cpan.org - Correspondence added
On 2016-11-25 05:34:23, RSCHUPP wrote: Show quoted text
> Breaks the "par_base" directive, patch attached. > > Cheers, Roderich
I wonder if there is a better way to fix this than adding '-I.' to the command line switches?
  Tue Apr 04 20:31:22 2017 The RT System itself - Status changed from 'new' to 'open'
  Fri Apr 14 07:33:08 2017 RSCHUPP [...] cpan.org - Correspondence added
On 2017-04-04 20:31:21, ETHER wrote: Show quoted text
> I wonder if there is a better way to fix this than adding '-I.' to the > command line switches?
Sorry, I don't understand the code in Module::Install etc. Anyway, according to the MetaCPAN Explorer there are only 6 distributions (excluding PAR::Packer) that include the file inc/Module/Install/PAR.pm. All but one don't use any method provided by Module::Install::PAR in their Makefile.PL. Hence inc/Module/Install/PAR.pm shouldn't have been included anyway, but perhaps because they use ancient versions of Module::Install or their authors didn't use the directoy inc/.author correctly. And the one distribution that uses par_base() has no need to do so, probably cargo-culted stuff. I've since removed the call of par_base() from PAR::Packer, so I guess this question is now rather academic. You may close this ticket at your disgression. Cheers, Roderich
  Fri Apr 14 13:30:07 2017 ether [...] cpan.org - Correspondence added
On 2017-04-14 04:33:08, RSCHUPP wrote: Show quoted text
> On 2017-04-04 20:31:21, ETHER wrote: >
> > I wonder if there is a better way to fix this than adding '-I.' to > > the > > command line switches?
> > Sorry, I don't understand the code in Module::Install etc.
Yup, neither do I :) Getting all users off of the Module::Install::* esoterica is a noble thing in its own right, so we can stop worrying about supporting so many edge cases. Glad to hear you were able to successfully migrate (at least in part)!