Skip Menu |

This queue is for tickets about the album CPAN distribution.

Report information
The Basics
Id: 11891
Status: resolved
Priority: 0/
Queue: album

People
Owner: Nobody in particular
Requestors: twan [...] roto.org
Cc:
AdminCc:

Bug Information
Severity: (no value)
Broken in: 1.01
Fixed in: (no value)



Subject: Album fails to recover from not being able to hard link a file
Album fails to recover from copying across filesystems. It attempts to revert to copying a file in stead of linking it, but this fails. See output from dummy run below: ---=== *** ===--- twan@arequipa.roto.loc75 mount /dev/hda2 on / type ext3 (rw) none on /proc type proc (rw) usbdevfs on /proc/bus/usb type usbdevfs (rw) /dev/hda1 on /boot type ext3 (rw) none on /dev/pts type devpts (rw,gid=5,mode=620) none on /dev/shm type tmpfs (rw) /dev/hdb1 on /home type ext3 (rw) /dev/hdc1 on /export/holdingdisk type ext3 (rw) twan@arequipa.roto.loc76 cd /export/holdingdisk/Fotos/ /export/holdingdisk/Fotos twan@arequipa.roto.loc77 mkdir large twan@arequipa.roto.loc78 touch info.dat twan@arequipa.roto.loc79 album -v --exif --medium --title "Dummy Test Run" --imp ort /home/twan/Camera/DCIM/101KCBOX No info.dat, adding images from large and /home/twan/Camera/DCIM/101KCBOX Updating info.dat Number of entries = 387 (387 added) mkdir thumbnails mkdir icons mkdir css mkdir medium Creating icons: index.png medium.png first.png first-gr.png last.png last-gr.png next.png next-gr.png prev.png prev-gr.png journal.png sound.png movie.jpg Creat ing style sheets: common.css index.css large.css medium.css journal.css 200502050131211334.JPG: link Attempt to use reference as lvalue in substr at /us r/bin/album line 1141, <DATA> line 267. Can't use string ("CODE(0x84ecopy ") as a subroutine ref while "strict refs" in use at /usr/bin/album line 1170, <DATA> line 267. twan@arequipa.roto.loc80 ---=== *** ===---
Show quoted text
> Can't use string ("CODE(0x84ecopy ") as a subroutine ref while "strict > refs" in
Please locate the code: elsif ( $linkthem ) { $msg->("link "); unless ( link($i_src, $i_large) == 1 ) { unlink($i_large); # just in case substr($msg,-5) = "copy "; copy($i_src, $i_large, $time); } } and change substr($msg,-5) = "copy "; into $msg->("copy "); and try again.
From: twan [...] roto.org
[JV - Tue Mar 15 16:50:07 2005]: Show quoted text
>
> > Can't use string ("CODE(0x84ecopy ") as a subroutine ref while "strict > > refs" in
> > Please locate the code: > > elsif ( $linkthem ) { > $msg->("link "); > unless ( link($i_src, $i_large) == 1 ) { > unlink($i_large); # just in case > substr($msg,-5) = "copy "; > copy($i_src, $i_large, $time); > } > } > > and change > > substr($msg,-5) = "copy "; > > into > > $msg->("copy "); > > and try again.
Clockwork: twan@arequipa.roto.loc41 cd /export/holdingdisk/Fotos/ /export/holdingdisk/Fotos twan@arequipa.roto.loc42 touch info.dat twan@arequipa.roto.loc43 mkdir large twan@arequipa.roto.loc44 album -v --exif --medium --title "Dummy test run" --imp ort /home/twan/Camera/DCIM/101KCBOX No info.dat, adding images from large and /home/twan/Camera/DCIM/101KCBOX Updating info.dat Number of entries = 387 (387 added) mkdir thumbnails mkdir icons mkdir css mkdir medium Creating icons: index.png medium.png first.png first-gr.png last.png last-gr.png next.png next-gr.png prev.png prev-gr.png journal.png sound.png movie.jpg Creat ing style sheets: common.css index.css large.css medium.css journal.css 200502050131211334.JPG: link copy medium thumbnail OK 200502050754391335.JPG: link copy medium thumbnail OK 200502050756011337.JPG: link copy medium thumbnail OK 200502060257411338.JPG: link copy medium thumbnail OK 200503150106201339.JPG: copy/rotate medium thumbnail OK 200502060333521340.JPG: link copy medium thumbnail OK 200502060334371341.JPG: link copy medium thumbnail OK ... twan@arequipa.roto.loc50 ls large/ total 22840 -rw-r----- 1 twan 2553486 Feb 5 01:31 200502050131211334.JPG -rw-r----- 1 twan 2353409 Feb 5 07:54 200502050754391335.JPG -rw-r----- 1 twan 2177659 Feb 5 07:56 200502050756011337.JPG -rw-r----- 1 twan 2866789 Feb 6 02:57 200502060257411338.JPG -rw-r----- 1 twan 2145236 Feb 6 03:33 200502060333521340.JPG -rw-r----- 1 twan 2623652 Feb 6 03:34 200502060334371341.JPG -rw-r----- 1 twan 1819712 Feb 6 04:49 200502060449191344.JPG -rw-r----- 1 twan 1478821 Feb 6 04:55 200502060455261345.JPG -rw-r----- 1 twan 633948 Feb 6 15:57 200502061557491348.JPG -rw-r----- 1 twan 2081061 Feb 6 23:41 200502062341561349.JPG -rw-r----- 1 twan 2587659 Mar 15 01:06 200503150106201339.JPG