Bug #118898 for Git-Sub: Git::Sub issue with Perl 5.8.9

Tue Nov 22 04:42:04 2016 book [...] cpan.org - Ticket created

Subject:

Git::Sub issue with Perl 5.8.9

Git::Database::Backend::Git::Sub uses Git::Sub to access the Git object database. It's test matrix is all green (yay!), except for one line: http://matrix.cpantesters.org/?dist=Git-Database%200.006;perl=5.8.9;reports=1 All of those FAIL show the same error: Unable to create sub named "git::cat_file" at /home/cpan/pit/bare/conf/perl-5.8.9/.cpanplus/5.8.9/build/F0SllIiKzn/Git-Sub-0.163130/blib/lib/Git/Sub.pm line 72, <DATA> chunk 1. Which leads me to think that Git::Sub has an issue with Perl 5.8.9.

Wed Nov 23 05:54:32 2016 dolmen [...] cpan.org - Correspondence added

I see that your code uses namespace::clean: https://github.com/book/Git-Database/blob/master/lib/Git/Database/Backend/Git/Sub.pm

Could it be a bad interaction of Git::Sub with namespace::clean as git::* subs are replaced on their first usage thanks to an AUTOLOAD ?

Could you try to wrap the Git::Sub import with "no namespace::clean" / "use namespace::clean"?

Le 2016-11-22 10:42:04, BOOK a écrit :
Show quoted text

> Git::Database::Backend::Git::Sub uses Git::Sub to access the Git
> object database.
> It's test matrix is all green (yay!), except for one line:
> http://matrix.cpantesters.org/?dist=Git-
> Database%200.006;perl=5.8.9;reports=1
>
> All of those FAIL show the same error:
>
> Unable to create sub named "git::cat_file" at
> /home/cpan/pit/bare/conf/perl-
> 5.8.9/.cpanplus/5.8.9/build/F0SllIiKzn/Git-Sub-
> 0.163130/blib/lib/Git/Sub.pm line 72, <DATA> chunk 1.
>
> Which leads me to think that Git::Sub has an issue with Perl 5.8.9.

--
Olivier Mengué - http://perlresume.org/DOLMEN

Wed Nov 23 05:54:32 2016 The RT System itself - Status changed from 'new' to 'open'

Sun Nov 27 11:33:07 2016 dolmen [...] cpan.org - Correspondence added

A fix by HAARG is now merged: https://github.com/dolmen-perl5/Git-Sub/pull/5

--
Olivier Mengué - http://perlresume.org/DOLMEN

Sun Nov 27 11:33:07 2016 dolmen [...] cpan.org - Status changed from 'open' to 'patched'

Wed Mar 01 16:52:00 2017 dolmen [...] cpan.org - Correspondence added

Fix released 3 months ago in https://metacpan.org/release/DOLMEN/Git-Sub-0.163320

--
Olivier Mengué - http://perlresume.org/DOLMEN

Wed Mar 01 16:52:05 2017 dolmen [...] cpan.org - Status changed from 'patched' to 'resolved'

Wed Mar 01 16:52:10 2017 dolmen [...] cpan.org - Fixed in 0.163320 added