| Subject: | Bogus error message for crc32 (no such file) |
| Date: | Mon, 21 Nov 2016 22:20:36 +0100 |
| To: | bug-Archive-Zip [...] rt.cpan.org |
| From: | Florian Schlichting <fsfs [...] debian.org> |
We have the following bug reported to the Debian package of
Archive-Zip (https://bugs.debian.org/762454):
------8<-----------8<-----------8<-----------8<-----------8<-----
Package: libarchive-zip-perl
Version: 1.38-1
Severity: minor
Assuming `foobar` is not a valid file, crc32 returns a bogus filename
(argv[0] ?) in the error message:
$ crc32 foobar
/usr/bin/crc32: No such file or directory
Thanks
------8<-----------8<-----------8<-----------8<-----------8<-----
The error message can be made unambiguous by adding a little more detail,
like so:
--- a/script/crc32
+++ b/script/crc32
@@ -21,7 +21,7 @@ foreach my $file (@ARGV) {
}
my $fh = FileHandle->new();
if ( !$fh->open( $file, 'r' ) ) {
- warn "$0: $!\n";
+ warn "$0: Cannot open $file: $!\n";
next;
}
binmode($fh);
Thanks for considering,
Florian Schlichting,
Debian Perl Group