Skip Menu |

This queue is for tickets about the Test-Smoke CPAN distribution.

Report information
The Basics
Id: 118879
Status: resolved
Priority: 0/
Queue: Test-Smoke

People
Owner: Nobody in particular
Requestors: jkeenan [...] cpan.org
Cc:
AdminCc:

Bug Information
Severity: (no value)
Broken in: (no value)
Fixed in: (no value)



Subject: Test::Smoke::App::RunSmoke::check_for_harness3: non-numeric comparison
check_for_harness3() has the following: ##### 145 sub check_for_harness3 { 146 my $self = shift; 147 ... 188 return $self->{_hasharness3} = $version >= 3; 189 } ##### Using Test::Smoke to test blead on FreeBSD today, at this point I got this warning: ##### [2016-11-21 09:21:54-0500] In pwd(/usr/home/jkeenan/p5smoke/perl-current) running: [2016-11-21 09:21:54-0500] qx[/usr/local/bin/perl -e "require q[/usr/home/jkeenan/p5smoke/perl-current/cpan/Test-Harness/lib/Test/Harness.pm];print Test::Harness->VERSION" 2>&1] Argument "3.36_01" isn't numeric in numeric ge (>=) at /usr/home/jkeenan/p5smoke/install/Test/Smoke/App/RunSmoke.pm line 188. [2016-11-21 09:21:54-0500] Found: Test::Harness version 3.36_01. [2016-11-21 09:21:54-0500] Reading build configurations from /usr/home/jkeenan/p5smoke/install/perlcurrent.cfg ##### In this particular case, stripping out the underscore before performing the '>=' would avoid the warning. But I don't know if that's the general solution to the problem. Thank you very much. Jim Keenan
On Mon Nov 21 13:22:32 2016, JKEENAN wrote: Show quoted text
> check_for_harness3() has the following: > > ##### > 145 sub check_for_harness3 { > 146 my $self = shift; > 147 > ... > 188 return $self->{_hasharness3} = $version >= 3; > 189 } > ##### > > Using Test::Smoke to test blead on FreeBSD today, at this point I got > this warning: > > ##### > [2016-11-21 09:21:54-0500] In pwd(/usr/home/jkeenan/p5smoke/perl- > current) running: > [2016-11-21 09:21:54-0500] qx[/usr/local/bin/perl -e "require > q[/usr/home/jkeenan/p5smoke/perl-current/cpan/Test- > Harness/lib/Test/Harness.pm];print Test::Harness->VERSION" 2>&1] > Argument "3.36_01" isn't numeric in numeric ge (>=) at > /usr/home/jkeenan/p5smoke/install/Test/Smoke/App/RunSmoke.pm line 188. > [2016-11-21 09:21:54-0500] Found: Test::Harness version 3.36_01. > [2016-11-21 09:21:54-0500] Reading build configurations from > /usr/home/jkeenan/p5smoke/install/perlcurrent.cfg > ##### > > In this particular case, stripping out the underscore before > performing the '>=' would avoid the warning. But I don't know if > that's the general solution to the problem. >
https://github.com/abeltje/Test-Smoke/pull/22
This will be in 1.70_11: commit 6ef0087e8297622913908b1d491f628c9a2d6317 (HEAD -> rt/118879, github/rt/118879) Author: abeltje <abeltje@test-smoke.org> Date: Sun May 14 11:36:29 2017 +0200 Handle 'development-releases' of Test::Harness in core Sometimes a "_nm" release of Test::Harness in blead, we need to deal with it. eval("$version") seems the easiest way.