Bug #118878 for Test-Smoke: Test::Smoke::Smoker: avoid uninitialized value warning

Mon Nov 21 13:09:49 2016 jkeenan [...] cpan.org - Ticket created

In Test::Smoke::Smoker, it is possible to get an "uninitialized value" warning when $self->{locale} has not previously been assigned a value. Here's an excerpt from a log file from a smoke run of blead on FreeBSD-11.0 today: ##### $ cat test_smoke_uninit_value.txt [2016-11-21 11:01:20-0500] Smoking branch blead [2016-11-21 11:01:20-0500] Locally applied patches from '/usr/home/jkeenan/p5smoke/perl-current/patchlevel.h' [2016-11-21 11:01:20-0500] Patches: 'uncommitted-changes' [2016-11-21 11:01:20-0500] Adding 'SMOKE3816c65ffd171a2958146bc01b5baa54793cd5fc' to the registered patches. [2016-11-21 11:01:20-0500] [2016-11-21 11:01:20-0500] Configuration: -Dusedevel [2016-11-21 11:01:20-0500] ------------------------------------------------------------------------------ [2016-11-21 11:01:20-0500] make distclean ... [2016-11-21 11:01:20-0500] [2016-11-21 11:01:20-0500] Copy Policy.sh ... [2016-11-21 11:01:20-0500] [2016-11-21 11:01:20-0500] Configure ... [2016-11-21 11:01:51-0500] [2016-11-21 11:01:51-0500] make ... magic: PERL_MAGIC_qr already provided by misc inflate.c:1487:9: warning: unused parameter 'subvert' [-Wunused-parameter] int subvert) ^ inflate.c:1507:61: warning: shifting a negative signed value is undefined [-Wshift-negative-value] if (strm == Z_NULL || strm->state == Z_NULL) return -1L << 16; ~~~ ^ 2 warnings generated. Warning (mostly harmless): No library found for -ldb magic: PERL_MAGIC_qr already provided by misc Warning (mostly harmless): No library found for -lndbm Warning (mostly harmless): No library found for -ldbm Warning (mostly harmless): No library found for -lucb Warning (mostly harmless): No library found for -lposix Warning (mostly harmless): No library found for -lcposix Making header files for XS... Use of uninitialized value in split at /usr/home/jkeenan/p5smoke/install/Test/Smoke/Smoker.pm line 529. [2016-11-21 11:04:53-0500] Skip tests from '/usr/home/jkeenan/p5smoke/install/smokecurrent.skiptests' ##### I am submitting a pull request to correct. Thank you very much. Jim Keenan

Mon Nov 21 13:14:13 2016 jkeenan [...] cpan.org - Subject changed from (no value) to 'Test::Smoke::Smoker: avoid uninitialized value warning'

Mon Nov 21 13:15:13 2016 jkeenan [...] cpan.org - Correspondence added

On Mon Nov 21 13:09:49 2016, JKEENAN wrote: Show quoted text

> In Test::Smoke::Smoker, it is possible to get an "uninitialized value" > warning when $self->{locale} has not previously been assigned a value. > Here's an excerpt from a log file from a smoke run of blead on > FreeBSD-11.0 today: > > ##### > $ cat test_smoke_uninit_value.txt > [2016-11-21 11:01:20-0500] Smoking branch blead > [2016-11-21 11:01:20-0500] Locally applied patches from > '/usr/home/jkeenan/p5smoke/perl-current/patchlevel.h' > [2016-11-21 11:01:20-0500] Patches: 'uncommitted-changes' > [2016-11-21 11:01:20-0500] Adding > 'SMOKE3816c65ffd171a2958146bc01b5baa54793cd5fc' to the registered > patches. > [2016-11-21 11:01:20-0500] > [2016-11-21 11:01:20-0500] Configuration: -Dusedevel > [2016-11-21 11:01:20-0500] > ------------------------------------------------------------------------------ > [2016-11-21 11:01:20-0500] make distclean ... > [2016-11-21 11:01:20-0500] > [2016-11-21 11:01:20-0500] Copy Policy.sh ... > [2016-11-21 11:01:20-0500] > [2016-11-21 11:01:20-0500] Configure ... > [2016-11-21 11:01:51-0500] > [2016-11-21 11:01:51-0500] make ... > magic: PERL_MAGIC_qr already provided by misc > inflate.c:1487:9: warning: unused parameter 'subvert' [-Wunused- > parameter] > int subvert) > ^ > inflate.c:1507:61: warning: shifting a negative signed value is > undefined [-Wshift-negative-value] > if (strm == Z_NULL || strm->state == Z_NULL) return -1L << 16; > ~~~ ^ > 2 warnings generated. > Warning (mostly harmless): No library found for -ldb > magic: PERL_MAGIC_qr already provided by misc > Warning (mostly harmless): No library found for -lndbm > Warning (mostly harmless): No library found for -ldbm > Warning (mostly harmless): No library found for -lucb > Warning (mostly harmless): No library found for -lposix > Warning (mostly harmless): No library found for -lcposix > Making header files for XS... > Use of uninitialized value in split at > /usr/home/jkeenan/p5smoke/install/Test/Smoke/Smoker.pm line 529. > [2016-11-21 11:04:53-0500] Skip tests from > '/usr/home/jkeenan/p5smoke/install/smokecurrent.skiptests' > ##### > > I am submitting a pull request to correct. >

https://github.com/abeltje/Test-Smoke/pull/21

Sat May 13 12:15:44 2017 abeltje [...] cpan.org - Correspondence added

Sadly, without any mention of your pull request (21): commit eb383a13a56ce0c84165d96720e58cea1005e496 (github/pullrequest18) Author: abeltje <abeltje@test-smoke.org> Date: Mon Jan 30 21:42:48 2017 +0100 Rsync from a git-repository should run Porting/make_dot_patch.pl Pullrequest 18: https://github.com/abeltje/Test-Smoke/pull/18 , implemented in a more general way (imo) - typo in configsmoke.pl

Sat May 13 12:15:44 2017 The RT System itself - Status changed from 'new' to 'open'

Sat May 13 12:15:44 2017 abeltje [...] cpan.org - Status changed from 'open' to 'resolved'