Skip Menu |

This queue is for tickets about the Module-ScanDeps CPAN distribution.

Report information
The Basics
Id: 118787
Status: rejected
Priority: 0/
Queue: Module-ScanDeps

People
Owner: Nobody in particular
Requestors: jkeenan [...] cpan.org
Cc:
AdminCc:

Bug Information
Severity: (no value)
Broken in: (no value)
Fixed in: (no value)



Subject: Circular dependency between Module::Install and Module::ScanDeps
A circular dependency exists between Module-Install and Module-ScanDeps. Going first to http://cpansearch.perl.org/src/ETHER/Module-Install-1.17/Makefile.PL, we find: ##### requires 'Module::ScanDeps' => '1.09'; #detects prereqs better ##### So Module::ScanDeps must be installed before we can attempt to install Module::Install. But if we now go to http://cpansearch.perl.org/src/RSCHUPP/Module-ScanDeps-1.22/Makefile.PL, we find: ##### use inc::Module::Install 1.00; ##### In other words, merely to get to 'make' with Module::ScanDeps, we must already have Module::Install installed. Implication: If we are unable to install one of these two libraries, we'll be unable to install the other. This is precisely the situation we find ourselves in when we attempt to build perl blead with the new '-Ddefault_inc_excludes_dot' configuration argument. I have built such a perl and then installed 'App::cpanminus' against it. When I attempt to use 'cpanm' to install either Module::Install or Module::ScanDeps against that perl, I fail for lack of the other. First, let's see what happens when I start by trying to install Module::Install. ##### $ ./bin/cpanm install Module::Install install is up to date. (0.01) --> Working on Module::Install Fetching http://www.cpan.org/authors/id/E/ET/ETHER/Module-Install-1.17.tar.gz ... OK Configuring Module-Install-1.17 ... OK ==> Found dependencies: Module::ScanDeps --> Working on Module::ScanDeps Fetching http://www.cpan.org/authors/id/R/RS/RSCHUPP/Module-ScanDeps-1.22.tar.gz ... OK Configuring Module-ScanDeps-1.22 ... N/A ! Configure failed for Module-ScanDeps-1.22. See /home/jkeenan/.cpanm/work/1479261391.29214/build.log for details. ! Installing the dependencies failed: Module 'Module::ScanDeps' is not installed ! Bailing out the installation for Module-Install-1.17. ##### Let's look at the log. ##### $ vi /home/jkeenan/.cpanm/work/1479261391.29214/build.log [snip] Checking if you have Module::ScanDeps 1.09 ... No [snip] ==> Found dependencies: Module::ScanDeps Searching Module::ScanDeps (1.09) on cpanmetadb ... --> Working on Module::ScanDeps Fetching http://www.cpan.org/authors/id/R/RS/RSCHUPP/Module-ScanDeps-1.22.tar.gz -> OK Unpacking Module-ScanDeps-1.22.tar.gz Entering Module-ScanDeps-1.22 Checking configure dependencies from META.yml Checking if you have ExtUtils::MakeMaker 6.59 ... Yes (7.24) Configuring Module-ScanDeps-1.22 Running Makefile.PL Can't locate inc/Module/Install.pm in @INC (you may need to install the inc::Module::Install module) (@INC contains: /home/jkeenan/testing/nodot/lib/perl5/site_perl/5.25.7/x86_64-linux /home/jkeenan/testing/nodot/lib/perl5/site_perl/5.25.7 /home/jkeenan/testing/nodot/lib/perl5/5.25.7/x86_64-linux /home/jkeenan/testing/nodot/lib/perl5/5.25.7) at Makefile.PL line 3. BEGIN failed--compilation aborted at Makefile.PL line 3. -> N/A -> FAIL Configure failed for Module-ScanDeps-1.22. See /home/jkeenan/.cpanm/work/1479261391.29214/build.log for details. -> FAIL Installing the dependencies failed: Module 'Module::ScanDeps' is not installed -> FAIL Bailing out the installation for Module-Install-1.17. Expiring 3 work directories. ##### Second, let's see what happens when I start by trying to install Module::ScanDeps. ##### $ ./bin/cpanm install Module::ScanDeps install is up to date. (0.01) --> Working on Module::ScanDeps Fetching http://www.cpan.org/authors/id/R/RS/RSCHUPP/Module-ScanDeps-1.22.tar.gz ... OK Configuring Module-ScanDeps-1.22 ... N/A ! Configure failed for Module-ScanDeps-1.22. See /home/jkeenan/.cpanm/work/1479261659.29269/build.log for details. ##### Looking into the next log file, we find: ##### $ vi /home/jkeenan/.cpanm/work/1479261659.29269/build.log [snip] Running Makefile.PL Can't locate inc/Module/Install.pm in @INC (you may need to install the inc::Module::Install module) (@INC contains: /home/jkeenan/testing/nodot/lib/perl5/site_perl/5.25.7/x86_64-linux /home/jkeenan/testing/nodot/lib/perl5/site_perl/5.25.7 /home/jkeenan/testing/nodot/lib/perl5/5.25.7/x86_64-linux /home/jkeenan/testing/nodot/lib/perl5/5.25.7) at Makefile.PL line 3. BEGIN failed--compilation aborted at Makefile.PL line 3. -> N/A -> FAIL Configure failed for Module-ScanDeps-1.22. See /home/jkeenan/.cpanm/work/1479261659.29269/build.log for details. ##### Speaking personally: I've never been a fan of Module::Install and have never used it in any my own libraries on CPAN or elsewhere. But at least one of my libraries has a dependency on File::HomeDir which, several years ago, was held up as the best practice for locating a home directory. File::HomeDir, in turn, has a dependency on Module::Install. So if Module::Install cannot be installed, then my own library cannot be installed. I therefore have a strong incentive to get Module::Install into a minimally functional state. A first step in that direction would be to break the circular dependency. My hunch is that it would be fairly straightforward to write a traditional, ExtUtils::MakeMaker-based Makefile.PL for Module::ScanDeps. That wouldn't solve all of Module::Install's problems -- see the large bug queue at https://rt.cpan.org/Dist/Display.html?Name=Module-Install -- but it would be one step forward. Shall we proceed along that line? If so, I will prepare a patch or a pull request. Thank you very much. Jim Keenan
On 2016-11-15 18:14:33, JKEENAN wrote: Show quoted text
> A circular dependency exists between Module-Install and Module- > ScanDeps.
No, the problem here is that Module-ScanDeps uses inc::Module::Install, which breaks with upcoming perls. Show quoted text
> I therefore have a strong incentive to get Module::Install into a > minimally functional state. A first step in that direction would be > to break the circular dependency. My hunch is that it would be fairly > straightforward to write a traditional, ExtUtils::MakeMaker-based > Makefile.PL for Module::ScanDeps.
It is my opinion that every distribution that uses MI should switch off of it, but that is not a new opinion -- it is merely bolstered by the new issues. I'm leaving this issue open as it's not my distribution, and the remedy is the same as proposed for the originally-conceived issue.
No issue here, as Karen has already explained. But I just switched Module::ScanDeps from Module::Install to ExtUtils::MakeMaker anyway. Cheers, Roderich
Subject: Re: [rt.cpan.org #118787] Circular dependency between Module::Install and Module::ScanDeps
Date: Wed, 16 Nov 2016 16:55:35 -0500
To: bug-Module-ScanDeps [...] rt.cpan.org, jkeenan [...] cpan.org
From: James E Keenan <jkeen [...] verizon.net>
On 11/16/2016 03:19 PM, Roderich Schupp via RT wrote: Show quoted text
> <URL: https://rt.cpan.org/Ticket/Display.html?id=118787 > > > No issue here, as Karen has already explained. > But I just switched Module::ScanDeps from Module::Install to ExtUtils::MakeMaker anyway. > > Cheers, Roderich >
And I can confirm that it now installs against a perl with '-Ddefault_inc_excludes_dot'. That moves us forward one step! Thank you very much for your speedy attention to this. Jim Keenan