Skip Menu |

This queue is for tickets about the Net-Kotonoha CPAN distribution.

Report information
The Basics
Id: 118738
Status: open
Priority: 0/
Queue: Net-Kotonoha

People
Owner: Nobody in particular
Requestors: SREZIC [...] cpan.org
Cc:
AdminCc:

Bug Information
Severity: (no value)
Broken in: 0.08
Fixed in: (no value)



Subject: Wrong usage of Test::Perl::Critic?
If Test::Perl::Critic is installed, then t/99-perlcritic.t fails --- probably due to wrong usage of the Test::Perl::Critic functions? You tried to run a test without a plan at /opt/perl-5.22.3-RC4/lib/site_perl/5.22.3/Test/Perl/Critic.pm line 104. Can't locate object method "done_testing" via package "Test::Builder" at /opt/perl-5.22.3-RC4/lib/site_perl/5.22.3/Test/Perl/Critic.pm line 110. t/99-perlcritic.t .... Dubious, test returned 1 (wstat 256, 0x100) No subtests run A lot of reports on CPAN Testers is red, probably because of this problem: http://matrix.cpantesters.org/?dist=Net-Kotonoha%200.08
On 2016-11-13 01:53:56, SREZIC wrote: Show quoted text
> If Test::Perl::Critic is installed, then t/99-perlcritic.t fails --- > probably due to wrong usage of the Test::Perl::Critic functions? > > > You tried to run a test without a plan at /opt/perl-5.22.3- > RC4/lib/site_perl/5.22.3/Test/Perl/Critic.pm line 104. > Can't locate object method "done_testing" via package "Test::Builder" > at /opt/perl-5.22.3-RC4/lib/site_perl/5.22.3/Test/Perl/Critic.pm line > 110. > t/99-perlcritic.t .... > Dubious, test returned 1 (wstat 256, 0x100) > No subtests run > > > A lot of reports on CPAN Testers is red, probably because of this > problem: > http://matrix.cpantesters.org/?dist=Net-Kotonoha%200.08
While this test failure is indeed an issue that should be corrected, please don't allow pod, critic, coverage or kwalitee tests to run for normal user installs, as they make the installation fail unnecessarily when newer versions of the tester module introduces errors that you cannot anticipate. Also spelling tests are dependent on what dictionaries are installed locally, and critic tests use all plugins that are installed, neither of which can be predicted in advance. Either move these tests to xt/, or guard them with: plan skip_all => "These tests are for authors only!" unless $ENV{AUTHOR_TESTING} or $ENV{RELEASE_TESTING};