Skip Menu |

This queue is for tickets about the XML-Fast CPAN distribution.

Report information
The Basics
Id: 118714
Status: new
Priority: 0/
Queue: XML-Fast
People
Owner: Nobody in particular
Requestors: ppisar [...] redhat.com
Cc:
AdminCc:
Bug Information
Severity: (no value)
Broken in: 0.11
Fixed in: (no value)

History Show all quoted text
  Fri Nov 11 07:56:57 2016 ppisar [...] redhat.com - Ticket created
Subject: Do not override OPTIMIZE by default
Makefile.PL set OPTIMIZE value. This undermines an aim to have all modules built in a uniform manner. I recommend to set OPTIMIZE only in the author mode.
Subject: 0001-Do-not-override-OPTIMIZE-by-default.patch
From d8ebfe1122f5e3018742b1d2d32211be90594a3a Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Petr=20P=C3=ADsa=C5=99?= <ppisar@redhat.com> Date: Fri, 11 Nov 2016 13:49:24 +0100 Subject: [PATCH] Do not override OPTIMIZE by default MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Signed-off-by: Petr Písař <ppisar@redhat.com> --- Makefile.PL | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Makefile.PL b/Makefile.PL index fbab6fd..45ccc69 100644 --- a/Makefile.PL +++ b/Makefile.PL @@ -17,8 +17,8 @@ WriteMakefile( INC => '-I.', $AUTHOR ? ( CCFLAGS => '-Wunused -std=c99', # only author mode + OPTIMIZE => '-g', ) : (), - OPTIMIZE => '-g', OBJECT => 'Fast.o xmlfast.o', # link all the C files too META_ADD => { license => 'perl' }, ); -- 2.7.4
  Tue Jun 27 02:39:46 2017 ppisar [...] redhat.com - Correspondence added
From: ppisar [...] redhat.com
Dne Pá 11.lis.2016 07:56:57, ppisar napsal(a): Show quoted text
> Makefile.PL set OPTIMIZE value. This undermines an aim to have all > modules built in a uniform manner. I recommend to set OPTIMIZE only in > the author mode.
A patch rebased to 0.16. It also fixes CFLAGS override that looses default $Config{ccflags} value required for preserving ABI between the interpreter and the XS module.
Subject: XML-Fast-0.16-Do-not-override-OPTIMIZE-by-default-and-do-not-lose-.patch
From 30d32c5b159b3d3eb7d2336b39fc5072fa8d234b Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Petr=20P=C3=ADsa=C5=99?= <ppisar@redhat.com> Date: Tue, 27 Jun 2017 08:24:26 +0200 Subject: [PATCH] Do not override OPTIMIZE by default and do not lose CFLAGS MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Overriding CFLAGS loses perl's ccflags value and that breaks ABI between libperl.so and the XS module. Overriding OPTIMIZE introduces irregularities into compiled code in context of large distribution package sets. Signed-off-by: Petr Písař <ppisar@redhat.com> --- Makefile.PL | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/Makefile.PL b/Makefile.PL index 88ac791..c3d9e57 100644 --- a/Makefile.PL +++ b/Makefile.PL @@ -1,5 +1,6 @@ use 5.008008; use ExtUtils::MakeMaker; +use Config; our $AUTHOR = -e '.gitignore'; if ($AUTHOR) { @@ -16,11 +17,10 @@ WriteMakefile( DEFINE => '', INC => '-I.', $AUTHOR ? ( - CCFLAGS => '-Wunused -std=c99', # only author mode + CCFLAGS => $Config{ccflags} . ' -Wunused -std=c99', # only author mode OPTIMIZE => '-g -O2 -funroll-loops', ) : ( - CCFLAGS => '-Wno-parentheses -Wno-pointer-sign', - OPTIMIZE => '-O2 -funroll-loops', + CCFLAGS => $Config{ccflags} . ' -Wno-parentheses -Wno-pointer-sign', ), OBJECT => 'Fast.o xmlfast.o', # link all the C files too META_ADD => { license => 'perl' }, -- 2.9.4