Bug #118441 for Net-Ping: Net::Ping-2.52 fails on MS Windows (t/001_new.t, t/410_syn

Wed Oct 19 16:11:53 2016 kmx [...] cpan.org - Ticket created

Subject:

Net::Ping-2.52 fails on MS Windows (t/001_new.t, t/410_syn_host.t)

Hi, I have experienced the following failure:

Running Makefile.PL
Configuring Net-Ping-2.52 ... Checking if your kit is complete...
Looks good
Generating a dmake-style Makefile
Writing Makefile for Net::Ping
Writing MYMETA.yml and MYMETA.json
OK
Checking dependencies from MYMETA.json ...
Checking if you have Time::HiRes 0 ... Yes (1.9726)
Checking if you have Test::More 0 ... Yes (1.001014)
Checking if you have ExtUtils::MakeMaker 0 ... Yes (7.10)
Checking if you have Socket 2.007 ... Yes (2.019)
Building and testing Net-Ping-2.52 ... cp lib/Net/Ping.pm blib\lib\Net\Ping.pm
"D:\strawberry32\perl\bin\perl.exe" "-MExtUtils::Command::MM" "-MTest::Harness" "-e" "undef *Test::Harness::Switches; test_harness(0, 'blib\lib', 'blib\arch')" t/*.t t/zz_legacy/*.t
t/000_load.t .......... 1/? # Testing Net::Ping 2.52, Perl 5.022000, D:\strawberry32\perl\bin\perl.exe
t/000_load.t .......... ok
t/001_new.t ........... 1/? # Checking icmp
icmp ping requires root privilege at t/001_new.t line 57.
# Looks like your test exited with 2 just after 9.
t/001_new.t ........... Dubious, test returned 2 (wstat 512, 0x200)
All 9 subtests passed
t/010_pingecho.t ...... ok
t/020_external.t ...... ok
t/110_icmp_inst.t ..... ok
t/120_udp_inst.t ...... ok
t/130_tcp_inst.t ...... ok
t/140_stream_inst.t ... ok
t/150_syn_inst.t ...... ok
t/190_alarm.t ......... ok
t/200_ping_tcp.t ...... ok
t/250_ping_hires.t .... ok
t/300_ping_stream.t ... skipped: loopback tcp echo service is off (No connection could be made because the target machine actively refused it.)
t/400_ping_syn.t ...... ok
t/410_syn_host.t ...... 1/19
#   Failed test 'supposed to be down: http://127.0.0.1/ [Timed out]'
t/410_syn_host.t ...... 12/19 #   at t/410_syn_host.t line 91.
#          got: '1'
#     expected: '0'
# Looks like you failed 1 test of 19.
t/410_syn_host.t ...... Dubious, test returned 1 (wstat 256, 0x100)
Failed 1/19 subtests
t/450_service.t ....... ok
t/500_ping_icmp.t ..... 'sudo' is not recognized as an internal or external command,
operable program or batch file.
t/500_ping_icmp.t ..... skipped: no sudo/failed
t/510_ping_udp.t ...... ok
t/520_icmp_ttl.t ...... ok
t/600_pod.t ........... ok
t/601_pod-coverage.t .. skipped: This test is only run for the module author

Test Summary Report
-------------------
t/001_new.t         (Wstat: 512 Tests: 9 Failed: 0)
  Non-zero exit status: 2
t/410_syn_host.t    (Wstat: 256 Tests: 19 Failed: 1)
  Failed test:  12
  Non-zero exit status: 1
Files=21, Tests=123, 58 wallclock secs ( 0.16 usr +  0.17 sys =  0.33 CPU)
Result: FAIL

Thu Oct 20 03:31:51 2016 RURBAN [...] cpan.org - Correspondence added

On Wed Oct 19 16:11:53 2016, KMX wrote: Show quoted text

> Hi, I have experienced the following failure:

... Show quoted text

> t/001_new.t (Wstat: 512 Tests: 9 Failed: 0) > Non-zero exit status: 2 > t/410_syn_host.t (Wstat: 256 Tests: 19 Failed: 1) > Failed test: 12 > Non-zero exit status: 1 > Files=21, Tests=123, 58 wallclock secs ( 0.16 usr + 0.17 sys = 0.33 > CPU) > Result: FAIL

Hi, Can you test this branch? I relaxed those tests of local icmp firewalls https://github.com/rurban/net-ping/tree/bugfix/rt-118441 -- Reini Urban

Thu Oct 20 03:31:52 2016 The RT System itself - Status changed from 'new' to 'open'

Thu Oct 20 03:46:20 2016 RURBAN [...] cpan.org - Correspondence added

On Thu Oct 20 03:31:51 2016, RURBAN wrote: Show quoted text

> On Wed Oct 19 16:11:53 2016, KMX wrote:

> > Hi, I have experienced the following failure:

> ...

> > t/001_new.t (Wstat: 512 Tests: 9 Failed: 0) > > Non-zero exit status: 2 > > t/410_syn_host.t (Wstat: 256 Tests: 19 Failed: 1) > > Failed test: 12 > > Non-zero exit status: 1 > > Files=21, Tests=123, 58 wallclock secs ( 0.16 usr + 0.17 sys = 0.33 > > CPU) > > Result: FAIL

> > Hi, > Can you test this branch? > I relaxed those tests of local icmp firewalls > > https://github.com/rurban/net-ping/tree/bugfix/rt-118441

I'm smoking it here: https://travis-ci.org/perl11/cperl/builds/169151825 https://ci.appveyor.com/project/rurban/cperl/build/5.25.2.1955 https://gitlab.com/perl11/cperl/pipelines/4675884 -- Reini Urban

Thu Oct 20 03:46:36 2016 kmx [...] cpan.org - Correspondence added

Yes, bugfix/rt-118441 works. Thanks for a prompt response.

y:\git\net-ping>dmake test
"D:\strawberry32\perl\bin\perl.exe" "-MExtUtils::Command::MM" "-MTest::Harness" "-e" "undef *Test::Harness::Switches; test_harness(0, 'blib\lib', 'blib\arch')" t/*.t t/zz_legacy/*.t
t/000_load.t .......... 1/? # Testing Net::Ping 2.53, Perl 5.022000, D:\strawberry32\perl\bin\perl.exe
t/000_load.t .......... ok
t/001_new.t ........... 1/? # Checking icmp
t/001_new.t ........... ok
t/010_pingecho.t ...... ok
t/020_external.t ...... ok
t/110_icmp_inst.t ..... ok
t/120_udp_inst.t ...... ok
t/130_tcp_inst.t ...... ok
t/140_stream_inst.t ... ok
t/150_syn_inst.t ...... ok
t/190_alarm.t ......... ok
t/200_ping_tcp.t ...... ok
t/250_ping_hires.t .... ok
t/300_ping_stream.t ... skipped: loopback tcp echo service is off (No connection could be made because the target machine actively refused it.)
t/400_ping_syn.t ...... ok
t/410_syn_host.t ...... ok
t/450_service.t ....... ok
t/500_ping_icmp.t ..... 'sudo' is not recognized as an internal or external command,
operable program or batch file.
t/500_ping_icmp.t ..... skipped: no sudo/failed
t/510_ping_udp.t ...... ok
t/520_icmp_ttl.t ...... ok
t/600_pod.t ........... ok
t/601_pod-coverage.t .. ok
All tests successful.
Files=21, Tests=126, 56 wallclock secs ( 0.08 usr +  0.11 sys =  0.19 CPU)
Result: PASS

Thu Oct 20 03:49:14 2016 RURBAN [...] cpan.org - Correspondence added

On Thu Oct 20 03:46:36 2016, KMX wrote: Show quoted text

> Yes, bugfix/rt-118441 works. Thanks for a prompt response. > > y:\git\net-ping>dmake test > "D:\strawberry32\perl\bin\perl.exe" "-MExtUtils::Command::MM" "- > MTest::Harness" "-e" "undef *Test::Harness::Switches; test_harness(0, > 'blib\lib', 'blib\arch')" t/*.t t/zz_legacy/*.t > t/000_load.t .......... 1/? # Testing Net::Ping 2.53, Perl 5.022000, > D:\strawberry32\perl\bin\perl.exe > t/000_load.t .......... ok > t/001_new.t ........... 1/? # Checking icmp > t/001_new.t ........... ok > t/010_pingecho.t ...... ok > t/020_external.t ...... ok > t/110_icmp_inst.t ..... ok > t/120_udp_inst.t ...... ok > t/130_tcp_inst.t ...... ok > t/140_stream_inst.t ... ok > t/150_syn_inst.t ...... ok > t/190_alarm.t ......... ok > t/200_ping_tcp.t ...... ok > t/250_ping_hires.t .... ok > t/300_ping_stream.t ... skipped: loopback tcp echo service is off (No > connection could be made because the target machine actively refused > it.) > t/400_ping_syn.t ...... ok > t/410_syn_host.t ...... ok > t/450_service.t ....... ok > t/500_ping_icmp.t ..... 'sudo' is not recognized as an internal or > external command, > operable program or batch file. > t/500_ping_icmp.t ..... skipped: no sudo/failed > t/510_ping_udp.t ...... ok > t/520_icmp_ttl.t ...... ok > t/600_pod.t ........... ok > t/601_pod-coverage.t .. ok > All tests successful. > Files=21, Tests=126, 56 wallclock secs ( 0.08 usr + 0.11 sys = 0.19 > CPU) > Result: PASS

Thanks for confirmation. Note that not all tests are firewall proof. I could relax all tests, but this doesn't make much sense. If I selectively firewall some hosts or ports, I still get a lot of test fails, as e.g. here, with outgoing port 80 blocked. t/200_ping_tcp.t (Wstat: 1792 Tests: 13 Failed: 7) Failed tests: 7-13 Non-zero exit status: 7 t/400_ping_syn.t (Wstat: 1536 Tests: 17 Failed: 6) Failed tests: 11-16 Non-zero exit status: 6 -- Reini Urban

Thu Oct 20 04:10:25 2016 RURBAN [...] cpan.org - Correspondence added

2.53 released -- Reini Urban

Thu Oct 20 04:10:31 2016 RURBAN [...] cpan.org - Status changed from 'open' to 'resolved'

Bug #118441 for Net-Ping: Net::Ping-2.52 fails on MS Windows (t/001_new.t, t/410_syn_host.t)