Skip Menu |

This queue is for tickets about the Pod-Perldoc CPAN distribution.

Report information
The Basics
Id: 118401
Status: patched
Priority: 0/
Queue: Pod-Perldoc

People
Owner: Nobody in particular
Requestors: RURBAN [...] cpan.org
Cc:
AdminCc:

Bug Information
Severity: (no value)
Broken in: (no value)
Fixed in: (no value)



Subject: t/02_module_pod_output.t issues
t/02_module_pod_output.t is trash: perl is not $^X FindBin and relative paths are not usable for PERL_CORE testing. See the attached patch. -- Reini Urban
Subject: 02_module_pod_output.patch
diff --git cpan/Pod-Perldoc/t/02_module_pod_output.t cpan/Pod-Perldoc/t/02_module_pod_output.t index abfaa2a..2129b40 100644 --- cpan/Pod-Perldoc/t/02_module_pod_output.t +++ cpan/Pod-Perldoc/t/02_module_pod_output.t @@ -4,7 +4,7 @@ use FindBin qw($Bin); use IPC::Open3; use Test::More; - +use Config; my $pid = undef; my $stdout = undef; @@ -17,6 +17,13 @@ my @dir = ($bindir,"lib","Pod"); my $podpath = File::Spec->catdir(@dir); my $good_podfile = File::Spec->catpath($volume,$podpath,"Perldoc.pm"); my $bad_podfile = File::Spec->catpath($volume,$podpath,"asdfsdaf.pm"); +if ($ENV{PERL_CORE}) { + $perldoc = File::Spec->catfile('..','..','utils', + ($Config{usecperl}?'c':'').'perldoc'); + @dir = ("lib","Pod"); + $good_podfile = File::Spec->catfile(@dir,"Perldoc.pm"); + $bad_podfile = File::Spec->catfile(@dir,"asdfsdaf.pm"); +} plan tests => 7; @@ -24,7 +31,7 @@ plan tests => 7; eval{ -$pid = open3(\*CHLD_IN,\*CHLD_OUT1,\*CHLD_ERR1,"perl " .$perldoc." ".$good_podfile); +$pid = open3(\*CHLD_IN,\*CHLD_OUT1,\*CHLD_ERR1,"$^X " .$perldoc." ".$good_podfile); }; @@ -51,7 +58,7 @@ $stderr = undef; eval{ -$pid = open3(\*CHLD_IN,\*CHLD_OUT2,\*CHLD_ERR2,"perl " .$perldoc." ".$bad_podfile); +$pid = open3(\*CHLD_IN,\*CHLD_OUT2,\*CHLD_ERR2,"$^X " .$perldoc." ".$bad_podfile); };
On Sat Oct 15 20:15:45 2016, RURBAN wrote: Show quoted text
> t/02_module_pod_output.t is trash: > See the attached patch.
Appreciate the patch. Thanks! Applied as f875ed8 and there's Pod-Perldoc 3.27_01 now on CPAN with this patch applied. I don't appreciate calling the test trash. It definitely has technical flaws but someone cared enough to write it.