Skip Menu |

This queue is for tickets about the DBD-SQLite CPAN distribution.

Report information
The Basics
Id: 118395
Status: resolved
Priority: 0/
Queue: DBD-SQLite

People
Owner: Nobody in particular
Requestors: ribasushi [...] leporine.io
Cc: xdg [...] xdg.me
AdminCc:

Bug Information
Severity: (no value)
Broken in: (no value)
Fixed in: (no value)



CC: xdg [...] xdg.me
Subject: DBD::SQLite 1.51_06+ will break the DBIC test suite
The newly bundled libsqlite 3.14+ allows among other things ... WHERE (foo, bar) IN ( SELECT foo, bar FROM ... ) ... There is a (very sloppily written by me) spot in the test suite of DBIC that expects the above to *not* function, and result in no modifications to the database: https://github.com/dbsrgits/dbix-class/blob/dc7d89911/t/resultset/update_delete.t#L155 https://metacpan.org/source/RIBASUSHI/DBIx-Class-0.082840/t/resultset/update_delete.t#L146 https://metacpan.org/source/RIBASUSHI/DBIx-Class-0.08271/t/resultset/update_delete.t#L116 Given the current disarray[1] it's probably sensible to delay shipping DBD::SQLite with 3.14+ (current DBD::SQlite 1.51_06 bundles 3.15.0), until someone steps up to work on DBIx::Class :/ [1] https://www.reddit.com/r/perl/comments/5734n9/summary_of_the_state_of_the_dbixclass_repository/d8oov13
On Sat Oct 15 22:46:54 2016, RIBASUSHI wrote: Show quoted text
> The newly bundled libsqlite 3.14+ allows among other things > > ... WHERE (foo, bar) IN ( SELECT foo, bar FROM ... ) ... > > There is a (very sloppily written by me) spot in the test suite of > DBIC that expects the above to *not* function, and result in no > modifications to the database: > https://github.com/dbsrgits/dbix- > class/blob/dc7d89911/t/resultset/update_delete.t#L155 > https://metacpan.org/source/RIBASUSHI/DBIx-Class- > 0.082840/t/resultset/update_delete.t#L146 > https://metacpan.org/source/RIBASUSHI/DBIx-Class- > 0.08271/t/resultset/update_delete.t#L116 > > Given the current disarray[1] it's probably sensible to delay shipping > DBD::SQLite with 3.14+ (current DBD::SQlite 1.51_06 bundles 3.15.0), > until someone steps up to work on DBIx::Class :/ > > [1] > https://www.reddit.com/r/perl/comments/5734n9/summary_of_the_state_of_the_dbixclass_repository/d8oov13
Shipped 1.51_07 with SQLite 3.13.0. I'll mark this ticket as stalled until the disarray is resolved. Thanks.
On Sun Oct 16 07:19:54 2016, ISHIGAKI wrote: Show quoted text
> > Shipped 1.51_07 with SQLite 3.13.0. I'll mark this ticket as stalled > until the disarray is resolved. Thanks.
Thank you for implementing this workaround, much appreciated!
Subject: Re: [rt.cpan.org #118395] DBD::SQLite 1.51_06+ will break the DBIC test suite
Date: Fri, 16 Dec 2016 10:52:35 +0100
To: bug-DBD-SQLite [...] rt.cpan.org
From: Peter Rabbitson <ribasushi [...] cpan.org>
On 10/16/2016 07:20 AM, Kenichi Ishigaki via RT wrote: Show quoted text
> Shipped 1.51_07 with SQLite 3.13.0. I'll mark this ticket as stalled until the disarray is resolved. Thanks.
Now that DBIx::Class is under new management, it's likely a good idea to revisit this ticket. Re-marking as 'open'. Please coordinate this with the force-assigned maints as per http://www.nntp.perl.org/group/perl.modules/2016/12/msg96582.html Cheers!
On Fri Dec 16 18:52:54 2016, RIBASUSHI wrote: Show quoted text
> On 10/16/2016 07:20 AM, Kenichi Ishigaki via RT wrote:
> > Shipped 1.51_07 with SQLite 3.13.0. I'll mark this ticket as stalled > > until the disarray is resolved. Thanks.
> > Now that DBIx::Class is under new management, it's likely a good idea > to > revisit this ticket. Re-marking as 'open'. > > Please coordinate this with the force-assigned maints as per > http://www.nntp.perl.org/group/perl.modules/2016/12/msg96582.html > > Cheers!
Sorry for the late reply. Thanks for the heads-up and also for your hard work and kindness for the past years!
On Sat Oct 15 15:46:54 2016, RIBASUSHI wrote: Show quoted text
> Given the current disarray[1] it's probably sensible to delay shipping > DBD::SQLite with 3.14+ (current DBD::SQlite 1.51_06 bundles 3.15.0), > until someone steps up to work on DBIx::Class :/
Ticket resolved, above no longer applies: https://metacpan.org/release/RIBASUSHI/DBIx-Class-0.082841