Bug #118391 for B-Debug: Test failure in current blead due to removal of OP

Fri Oct 14 23:53:52 2016 DCOLLINS [...] cpan.org - Ticket created

Subject:

Test failure in current blead due to removal of OP_PUSHRE

Hello! I'm testing perl modules against development versions of Perl, in an attempt to identify backcompat changes and regressions. It looks like your module relies on some behaviour that is going to change. Specifically, Perl 5 commit v5.25.5-65-g5012eeb changes the optree generated from code like "split(//, ...)". OP_SPLIT no longer has OP_PUSHRE as a child, OP_PUSHRE has been removed and OP_SPLIT has been changed from a listop to a pmop. You can find more information in the commit message here: http://perl5.git.perl.org/perl.git/commitdiff/5012eebe5586df96a1869edfedea1382aa254085 This has caused your testsuite to start failing when run with the current development "blead" version of perl, and this change will likely be incorporated in v5.25.6 (to be released about 2016-10-20) and v5.26.0 (2017-04-20). I've attached two test reports of your module - one passing on v5.25.5, one failing on blead - to help diagnose the issue. Respectfully, Dan Collins

Subject:

fail.B-Debug-1.23.x86_64-linux-thread-multi.3.16.0-4-amd64.1476465238.32064.rpt

Download fail.B-Debug-1.23.x86_64-linux-thread-multi.3.16.0-4-amd64.1476465238.32064.rpt
application/octet-stream 8k

Message body not shown because it is not plain text.

Subject:

pass.B-Debug-1.23.x86_64-linux-thread-multi.3.16.0-4-amd64.1476465261.423.rpt

Download pass.B-Debug-1.23.x86_64-linux-thread-multi.3.16.0-4-amd64.1476465261.423.rpt
application/octet-stream 7k

Message body not shown because it is not plain text.

Sat Oct 15 03:52:32 2016 reini.urban [...] gmail.com - Correspondence added

Subject:	Re: [rt.cpan.org #118391] Test failure in current blead due to removal of OP_PUSHRE
Date:	Sat, 15 Oct 2016 09:52:21 +0200
To:	bug-B-Debug [...] rt.cpan.org
From:	Reini Urban <reini.urban [...] gmail.com>

Show quoted text

> Ticket <URL: https://rt.cpan.org/Ticket/Display.html?id=118391 > > > > I'm testing perl modules against development versions of Perl, in an attempt to identify backcompat changes and regressions. It looks like your module relies on some behaviour that is going to change. > > Specifically, Perl 5 commit v5.25.5-65-g5012eeb changes the optree generated from code like "split(//, ...)". OP_SPLIT no longer has OP_PUSHRE as a child, OP_PUSHRE has been removed and OP_SPLIT has been changed from a listop to a pmop. You can find more information in the commit message here: http://perl5.git.perl.org/perl.git/commitdiff/5012eebe5586df96a1869edfedea1382aa254085 > > This has caused your testsuite to start failing when run with the current development "blead" version of perl, and this change will likely be incorporated in v5.25.6 (to be released about 2016-10-20) and v5.26.0 (2017-04-20).

Wouldn’t it be much easier to remove B::Debug from CORE? I don’t think there’s need for it, as B::Concise it much better. The fixes are trivial, yes. Will do sooner or later. Patches appreciated. The B::C compiler breakage is much bigger, btw. Reini Urban rurban@cpan.org

Sat Oct 15 03:52:33 2016 The RT System itself - Status changed from 'new' to 'open'

Tue Jul 25 07:40:56 2017 jkeenan [...] cpan.org - Correspondence added

On Sat Oct 15 03:52:32 2016, reini.urban@gmail.com wrote: Show quoted text

> > Ticket <URL: https://rt.cpan.org/Ticket/Display.html?id=118391 > > > > > > > I'm testing perl modules against development versions of Perl, in an > > attempt to identify backcompat changes and regressions. It looks like > > your module relies on some behaviour that is going to change. > > > > Specifically, Perl 5 commit v5.25.5-65-g5012eeb changes the optree > > generated from code like "split(//, ...)". OP_SPLIT no longer has > > OP_PUSHRE as a child, OP_PUSHRE has been removed and OP_SPLIT has > > been changed from a listop to a pmop. You can find more information > > in the commit message here: > > http://perl5.git.perl.org/perl.git/commitdiff/5012eebe5586df96a1869edfedea1382aa254085 > > > > This has caused your testsuite to start failing when run with the > > current development "blead" version of perl, and this change will > > likely be incorporated in v5.25.6 (to be released about 2016-10-20) > > and v5.26.0 (2017-04-20).

> > Wouldn’t it be much easier to remove B::Debug from CORE?

Removed from the core distribution in commit ecfa068aa0dab432bfdef423766b665be127ef77 CommitDate: Tue Jul 25 07:18:22 2017 Show quoted text

> I don’t think there’s need for it, as B::Concise it much better. > > The fixes are trivial, yes. Will do sooner or later. > Patches appreciated. > > The B::C compiler breakage is much bigger, btw. > > Reini Urban > rurban@cpan.org

Tue Jul 25 10:59:25 2017 ilmari+cpan [...] ilmari.org - Correspondence added

On 2017-07-25 12:40:56, JKEENAN wrote: Show quoted text

> On Sat Oct 15 03:52:32 2016, reini.urban@gmail.com wrote:

> > Wouldn’t it be much easier to remove B::Debug from CORE?

> > Removed from the core distribution in commit > ecfa068aa0dab432bfdef423766b665be127ef77 > > CommitDate: Tue Jul 25 07:18:22 2017

Perl policy requires removal of features and modules to be preceded by a deprecation warning for at least one stable release cycle, so this has been reverted in commit 9e01a143b7fab68250d5e07d6897a0f311092e59. This ticket can be closed (it was fixed in 1.24). I'll file a separate ticket to make B::Debug warn when the core-shipped version is used.

Sun Dec 03 15:38:47 2017 RURBAN [...] cpan.org - Correspondence added

Both issues are resolved -- Reini Urban

Sun Dec 03 15:38:47 2017 RURBAN [...] cpan.org - Status changed from 'open' to 'resolved'

Bug #118391 for B-Debug: Test failure in current blead due to removal of OP_PUSHRE