Skip Menu |

This queue is for tickets about the Image-Magick-Text-AutoBreak CPAN distribution.

Report information
The Basics
Id: 118361
Status: open
Priority: 0/
Queue: Image-Magick-Text-AutoBreak

People
Owner: Nobody in particular
Requestors: SREZIC [...] cpan.org
Cc:
AdminCc:

Bug Information
Severity: (no value)
Broken in: 0.02
Fixed in: (no value)



Subject: perlcritic test may fail
On my smoker systems I see the following failure: # Failed test 'Test::Perl::Critic for "lib/Image/Magick/Text/AutoBreak.pm"' # at /opt/perl-5.24.0/lib/site_perl/5.24.0/Test/Perl/Critic.pm line 104. # # Variable, subroutine, and package names have to be in CamelCase at line 14, column 8. (no explanation). (Severity: 5) # Variable, subroutine, and package names have to be in CamelCase at line 15, column 8. (no explanation). (Severity: 5) # Variable, subroutine, and package names have to be in CamelCase at line 29, column 18. (no explanation). (Severity: 5) # Variable, subroutine, and package names have to be in CamelCase at line 31, column 8. (no explanation). (Severity: 5) # Variable, subroutine, and package names have to be in CamelCase at line 33, column 3. (no explanation). (Severity: 5) ... (snipped) ... Probably this happens only if Test::Perl::Critic and Perl::Critic::OTRS are installed.
On 2016-10-12 23:49:03, SREZIC wrote: Show quoted text
> On my smoker systems I see the following failure: > > # Failed test 'Test::Perl::Critic for > "lib/Image/Magick/Text/AutoBreak.pm"' > # at /opt/perl-5.24.0/lib/site_perl/5.24.0/Test/Perl/Critic.pm line > 104. > # > # Variable, subroutine, and package names have to be in CamelCase at > line 14, column 8. (no explanation). (Severity: 5) > # Variable, subroutine, and package names have to be in CamelCase at > line 15, column 8. (no explanation). (Severity: 5) > # Variable, subroutine, and package names have to be in CamelCase at > line 29, column 18. (no explanation). (Severity: 5) > # Variable, subroutine, and package names have to be in CamelCase at > line 31, column 8. (no explanation). (Severity: 5) > # Variable, subroutine, and package names have to be in CamelCase at > line 33, column 3. (no explanation). (Severity: 5) > ... (snipped) ... > > > Probably this happens only if Test::Perl::Critic and > Perl::Critic::OTRS are installed.
While this test failure is indeed an issue that should be corrected, please don't allow pod, critic, coverage or kwalitee tests to run for normal user installs, as they make the installation fail unnecessarily when newer versions of the tester module introduces errors that you cannot anticipate. Also spelling tests are dependent on what dictionaries are installed locally, and critic tests use all plugins that are installed, neither of which can be predicted in advance. Either move these tests to xt/, or guard them with: plan skip_all => "These tests are for authors only!" unless $ENV{AUTHOR_TESTING} or $ENV{RELEASE_TESTING};