Bug #118262 for MIME-tools: Test t/Ref.t fails on Windows install

Tue Oct 04 15:45:02 2016 mark.solinski [...] gpsinsight.com - Ticket created

Subject:	Test t/Ref.t fails on Windows install
Date:	Tue, 4 Oct 2016 19:44:43 +0000
To:	"bug-MIME-tools [...] rt.cpan.org" <bug-MIME-tools [...] rt.cpan.org>
From:	Mark Solinski <mark.solinski [...] gpsinsight.com>

Hello, There is a hack (labeled as such in t/Ref.h) which looks like this: ### HACK HACK HACK: MailTools behaviour has changed!!! if ($msgpath eq 'testmsgs/hdr-fakeout.msg' && $::Mail::Header::VERSION > 2.14) { $refpath = 'testmsgs/hdr-fakeout-newmailtools-ref'; } The problem is the test "$msgpath eq 'testmsgs/hdr-fakeout.msg'" which when executed via the Windows (command) shell, will always fail. This is because, on Windows, the $msgpath variable will look something like "testmsgs\\hdr-fakeout.msg". On the Windows platform, the standard path separator is '\' and not '/'. Since Windows can use either separators, a fix will require, either that $msgpath only uses the '/' separator or the comparison needs to be relaxed to handle both separators. When I insured that $msgpath only used the '/' separator (and $::Mail::Header::VERSION was equal to 2.18), $refpath was set and all the tests passed. Mark Solinski | Back End Development Manager GPS Insight 7201 E. Henkel Way, Suite 400 | Scottsdale, AZ 85255 866.477.4321 Office x8596 480.513.1694 Fax 847.338.2006 Mobile gpsinsight.com [../Desktop/gpsi_logo_flat.jpg]

Download image001.jpg
image/jpeg 15.2k

Tue Oct 04 16:42:08 2016 dfs+pause [...] roaringpenguin.com - Taken

Tue Oct 04 16:44:14 2016 dfs [...] roaringpenguin.com - Correspondence added

Subject:	Re: [rt.cpan.org #118262] Test t/Ref.t fails on Windows install
Date:	Tue, 4 Oct 2016 16:42:50 -0400
To:	bug-MIME-tools [...] rt.cpan.org
From:	Dianne Skoll <dfs [...] roaringpenguin.com>

Hi, Show quoted text

> There is a hack (labeled as such in t/Ref.h) which looks like this:

Oh, I see. Does this patch-to-a-hack fix things on Windows? Regards, Dianne. diff --git a/t/Ref.t b/t/Ref.t index d39d20b..7d89b32 100644 --- a/t/Ref.t +++ b/t/Ref.t @@ -40,7 +40,8 @@ foreach my $refpath (@refpaths) { # print STDERR " $msgpath\n"; ### HACK HACK HACK: MailTools behaviour has changed!!! - if ($msgpath eq 'testmsgs/hdr-fakeout.msg' && $::Mail::Header::VERSION > 2.14) { + if ($msgpath =~ /hdr-fakeout.msg$/ && + $::Mail::Header::VERSION > 2.14) { $refpath = 'testmsgs/hdr-fakeout-newmailtools-ref'; } ### Get reference, as ref to array:

Tue Oct 04 16:44:14 2016 The RT System itself - Status changed from 'new' to 'open'

Tue Oct 04 18:00:02 2016 mark.solinski [...] gpsinsight.com - Correspondence added

Subject:	RE: [rt.cpan.org #118262] Test t/Ref.t fails on Windows install
Date:	Tue, 4 Oct 2016 21:59:42 +0000
To:	"bug-MIME-tools [...] rt.cpan.org" <bug-MIME-tools [...] rt.cpan.org>
From:	Mark Solinski <mark.solinski [...] gpsinsight.com>

Yes. With that patch-to-a-hack, all tests pass on Windows (Perl 5.22.1, MSWin32-x64-multi-thread). Thanks, Mark Show quoted text

-----Original Message----- From: Dianne Skoll via RT [mailto:bug-MIME-tools@rt.cpan.org] Sent: Tuesday, October 04, 2016 1:44 PM To: Mark Solinski <mark.solinski@gpsinsight.com> Subject: Re: [rt.cpan.org #118262] Test t/Ref.t fails on Windows install <URL: https://rt.cpan.org/Ticket/Display.html?id=118262 > Hi,

> There is a hack (labeled as such in t/Ref.h) which looks like this:

Oh, I see. Does this patch-to-a-hack fix things on Windows? Regards, Dianne. diff --git a/t/Ref.t b/t/Ref.t index d39d20b..7d89b32 100644 --- a/t/Ref.t +++ b/t/Ref.t @@ -40,7 +40,8 @@ foreach my $refpath (@refpaths) { # print STDERR " $msgpath\n"; ### HACK HACK HACK: MailTools behaviour has changed!!! - if ($msgpath eq 'testmsgs/hdr-fakeout.msg' && $::Mail::Header::VERSION > 2.14) { + if ($msgpath =~ /hdr-fakeout.msg$/ && + $::Mail::Header::VERSION > 2.14) { $refpath = 'testmsgs/hdr-fakeout-newmailtools-ref'; } ### Get reference, as ref to array:

Sat Mar 18 18:46:56 2017 XENU [...] cpan.org - Correspondence added

Hi Dianne, Could you please release a new MIME::Tools version with that patch? Thank you

Wed Apr 05 11:46:05 2017 jason [...] froebe.net - Correspondence added

On Sat Mar 18 18:46:56 2017, XENU wrote: Show quoted text

> Hi Dianne, > > Could you please release a new MIME::Tools version with that patch? > > Thank you

I ran into this issue as well. A new release would help :)

Fri Apr 07 10:03:36 2017 dfs+pause [...] roaringpenguin.com - Correspondence added

Hi, I've released version 5.509 of MIME::tools at http://search.cpan.org/~dskoll/MIME-tools-5.509/ I believe it fixes this bug. Regards, Dianne.

Fri Apr 07 10:03:41 2017 dfs+pause [...] roaringpenguin.com - Status changed from 'open' to 'resolved'