| Subject: | Upcoming DBIC is starting to warn on implicit 'select star' invocations, failing S::L's tests |
As of https://github.com/dbsrgits/dbix-class/commit/02562a20 the passthrough of SQL::Abstract behavior on empty list has been deprecated, which in turn trips up the warning-counting part of the test suite.
Proposed solution:
--- a/lib/DBIx/Class/Schema/Loader/DBI.pm
+++ b/lib/DBIx/Class/Schema/Loader/DBI.pm
@@ -273,7 +273,7 @@ sub _sth_for {
my ($self, $table, $fields, $where) = @_;
my $sth = $self->dbh->prepare($self->schema->storage->sql_maker
- ->select(\$table->sql_name, $fields, $where));
+ ->select(\$table->sql_name, $fields || \'*', $where));
return $sth;
}