Bug #118162 for Footprintless: Using File::Temp::HIGH() is problematic

Fri Sep 30 02:35:04 2016 SREZIC [...] cpan.org - Ticket created

Subject:

Using File::Temp::HIGH() is problematic

The test suite fails on my smoker machines: ... Error in tempfile() using template /run/user/1023/cpansmoker/2016092818/fpl_XXXXXXXX.war: Parent directory (/run/user/1023/cpansmoker/2016092818/) is not safe (Sticky bit not set on /run/user/1023/cpansmoker/2016092818/ when dir is group|world writable) at /tmpfs/.cpan-build-cpansand/2016092818/Footprintless-1.16-2/blib/lib/Footprintless/Util.pm line 250. # Looks like your test exited with 2 just after 32. t/Footprintless_Deployment.t ............. ... The error message here is wrong; the temporary directory is very safe (/run/user/$uid is created by the operating system with just permissions for this user, and the actual directory is indeed group writable, but the members of this group are known). Probably it's best to not set File::Temp's safe_level here; this can still be done by the module caller as this is a global operation (which is also not good to be done in a module). Regards, Slaven

Mon Oct 03 04:47:48 2016 SREZIC [...] cpan.org - Correspondence added

On 2016-09-30 02:35:04, SREZIC wrote: Show quoted text

> The test suite fails on my smoker machines: > > ... > Error in tempfile() using template > /run/user/1023/cpansmoker/2016092818/fpl_XXXXXXXX.war: Parent > directory (/run/user/1023/cpansmoker/2016092818/) is not safe (Sticky > bit not set on /run/user/1023/cpansmoker/2016092818/ when dir is > group|world writable) at /tmpfs/.cpan-build- > cpansand/2016092818/Footprintless-1.16- > 2/blib/lib/Footprintless/Util.pm line 250. > # Looks like your test exited with 2 just after 32. > t/Footprintless_Deployment.t ............. > ... > > The error message here is wrong; the temporary directory is very safe > (/run/user/$uid is created by the operating system with just > permissions for this user, and the actual directory is indeed group > writable, but the members of this group are known). Probably it's best > to not set File::Temp's safe_level here; this can still be done by the > module caller as this is a global operation (which is also not good to > be done in a module).

I changed my smokers to create temporary directories with 0755 instead of 0775, so there should be no more failures from my smoker systems. However, I still think the report here should be considered. Regards, Slaven

Wed Oct 12 18:45:06 2016 LTHEISEN [...] cpan.org - Correspondence added

Thanks for the report, this issue is resolved in: commit 1c3509413797bc58e9fdac773584dbe49980a1a8 Author: Lucas Theisen <lucastheisen@pastdev.com> Date: Wed Oct 12 18:44:16 2016 -0400 resolved https://rt.cpan.org/Ticket/Display.html?id=118162 Using File::Temp::HIGH() is problematic I will be cutting a new release soon.

Wed Oct 12 18:45:06 2016 The RT System itself - Status changed from 'new' to 'open'

Wed Oct 12 18:45:07 2016 LTHEISEN [...] cpan.org - Status changed from 'open' to 'resolved'