Skip Menu |

This queue is for tickets about the DateTime-Fiction-JRRTolkien-Shire CPAN distribution.

Report information
The Basics
Id: 118158
Status: resolved
Priority: 0/
Queue: DateTime-Fiction-JRRTolkien-Shire

People
Owner: Nobody in particular
Requestors: wyant [...] cpan.org
Cc:
AdminCc:

Bug Information
Severity: Unimportant
Broken in: (no value)
Fixed in: 0.19_01



Subject: on_date() text corrections
This is a set of patches of typos in the on_date() text. It corresponds to Date-Tolkien-Shire ticket https://rt.cpan.org/Ticket/Display.html?id=118043
Subject: DateTime-Fiction-JRRTolkien-Shire-ondate.patch
--- t/05ondate.old 2003-12-07 15:40:00.000000000 -0500 +++ t/05ondate.t 2016-09-29 19:08:13.000000000 -0400 @@ -7,4 +7,4 @@ my $shire = DateTime::Fiction::JRRTolkien::Shire->new(year => 7463, month => 1, day => 8); -is($shire->on_date, "Sunday 8 Afteryule 7463\n\nThe Company of the Ring reaches Holland, 1419.\n"); +is($shire->on_date, "Sunday 8 Afteryule 7463\n\nThe Company of the Ring reaches Hollin, 1419.\n");
Subject: DateTime-Fiction-JRRTolkien-Shire.patch
--- lib/DateTime/Fiction/JRRTolkien/Shire.old 2003-12-07 16:10:08.000000000 -0500 +++ lib/DateTime/Fiction/JRRTolkien/Shire.pm 2016-09-29 19:03:49.000000000 -0400 @@ -554,7 +554,7 @@ # the day matches up $events{0} = { 3 => "Wedding of King Elessar and Arwen, 1419.\n" }; - $events{1} = { 8 => "The Company of the Ring reaches Holland, 1419.\n", + $events{1} = { 8 => "The Company of the Ring reaches Hollin, 1419.\n", 13 => "The Company of the Ring reaches the West-gate of Moria at nightfall, 1419.\n", 14 => "The Company of the Ring spends the night in Moria hall 21, 1419.\n", 15 => "The Bridge of Khazad-dum, and the fall of Gandalf, 1419.\n", @@ -576,7 +576,7 @@ "Eomer hears of the descent of the Orc-band from Emyn Muil, 1419.\n" . "Frodo and Samwise enter the eastern Emyn Muil, 1419.\n", 27 => "Aragorn reaches the west-cliff at sunrise, 1419.\n" . - "Eomer sets out Eastfold against Theoden's orders to pursue the Orcs, 1419.\n", + "Eomer sets out from Eastfold against Theoden's orders to pursue the Orcs, 1419.\n", 28 => "Eomer overtakes the Orcs just outside of Fangorn Forest, 1419.\n", 29 => "Meriodoc and Pippin escape and meet Treebeard, 1419.\n" . "The Rohirrim attack at sunrise and destroy the Orcs, 1419.\n" . @@ -610,7 +610,7 @@ 11 => "Gollum visits Shelob, 1419.\n" . "Denethor sends Faramir to Osgiliath, 1419.\n" . "Eastern Rohan is invaded and Lorien assaulted, 1419.\n", - 12 => "Gollum leads Frodo in Shelob's lair, 1419.\n" . + 12 => "Gollum leads Frodo into Shelob's lair, 1419.\n" . "Ents defeat the invaders of Rohan, 1419.\n", 13 => "Frodo captured by the Orcs of Cirith Ungol, 1419.\n" . "The Pelennor is overrun and Faramir is wounded, 1419.\n" . @@ -663,7 +663,7 @@ " they drive off the guard of Rangers, 1418.\n" . "Saruman comes to the Shire, 1419.\n", 23 => "Four Black Riders enter the shire before dawn. The others pursue \n" . - "the Rangers eastword and then return to watch the Greenway, 1418.\n" . + "the Rangers eastward and then return to watch the Greenway, 1418.\n" . "A Black Rider comes to Hobbiton at nightfall, 1418.\n" . "Frodo leaves Bag End, 1418.\n" . "Gandalf having tamed Shadowfax rides from Rohan, 1418.\n", @@ -677,7 +677,7 @@ }; $events{10} = { 3 => "Gandalf attacked at night on Weathertop, 1418.\n", 5 => "Gandalf and the Hobbits leave Rivendell, 1419.\n", - 6 => "The camp under weathertop is attacked at night and Frodo is wounded, 1418.\n", + 6 => "The camp under Weathertop is attacked at night and Frodo is wounded, 1418.\n", 11 => "Glorfindel drives the Black Riders off the Bridge of Mitheithel, 1418.\n", 13 => "Frodo crosses the Bridge of Mitheithel, 1418.\n", 18 => "Glorfindel finds Frodo at dusk, 1418.\n" .
A GitHub repository containing the changes for this patch is at https://github.com/trwyant/perl-DateTime-Fiction-JRRTolkien-Shire Is there anything I can do to help with this? If you will grant me co-maintainer status I am willing to make the release.