Skip Menu |

This queue is for tickets about the TRD-Watch-Ping CPAN distribution.

Report information
The Basics
Id: 118142
Status: open
Priority: 0/
Queue: TRD-Watch-Ping
People
Owner: Nobody in particular
Requestors: SREZIC [...] cpan.org
Cc:
AdminCc:
Bug Information
Severity: (no value)
Broken in: 0.0.4
Fixed in: (no value)

History Show all quoted text
  Thu Sep 29 14:16:42 2016 SREZIC [...] cpan.org - Ticket created
Subject: perlcritic test may fail
t/perlcritic.t may fail like this (probably only if Perl::Critic::OTRS is installed): ... # Failed test 'Test::Perl::Critic for "blib/lib/TRD/Watch/Ping.pm"' # at /opt/perl-5.25.5/lib/site_perl/5.25.5/Test/Perl/Critic.pm line 104. # # Variable, subroutine, and package names have to be in CamelCase at line 20, column 5. (no explanation). (Severity: 5) # Variable, subroutine, and package names have to be in CamelCase at line 21, column 5. (no explanation). (Severity: 5) # Variable, subroutine, and package names have to be in CamelCase at line 25, column 5. (no explanation). (Severity: 5) # Variable, subroutine, and package names have to be in CamelCase at line 26, column 5. (no explanation). (Severity: 5) # Variable, subroutine, and package names have to be in CamelCase at line 27, column 5. (no explanation). (Severity: 5) # Variable, subroutine, and package names have to be in CamelCase at line 28, column 5. (no explanation). (Severity: 5) # Variable, subroutine, and package names have to be in CamelCase at line 29, column 5. (no explanation). (Severity: 5) # Variable, subroutine, and package names have to be in CamelCase at line 30, column 5. (no explanation). (Severity: 5) # Variable, subroutine, and package names have to be in CamelCase at line 30, column 31. (no explanation). (Severity: 5) # Variable, subroutine, and package names have to be in CamelCase at line 31, column 5. (no explanation). (Severity: 5) # Variable, subroutine, and package names have to be in CamelCase at line 31, column 32. (no explanation). (Severity: 5) # Perlsecret risk. Venus at line 33, column 3. Perlsecret detected: %s. (Severity: 5) ...
  Thu Sep 29 15:52:46 2016 ether [...] cpan.org - Correspondence added
On 2016-09-29 11:16:42, SREZIC wrote: Show quoted text
> t/perlcritic.t may fail like this (probably only if Perl::Critic::OTRS > is installed): > > ... > # Failed test 'Test::Perl::Critic for "blib/lib/TRD/Watch/Ping.pm"' > # at /opt/perl-5.25.5/lib/site_perl/5.25.5/Test/Perl/Critic.pm line > 104. > # > # Variable, subroutine, and package names have to be in CamelCase at > line 20, column 5. (no explanation). (Severity: 5) > # Variable, subroutine, and package names have to be in CamelCase at > line 21, column 5. (no explanation). (Severity: 5) > # Variable, subroutine, and package names have to be in CamelCase at > line 25, column 5. (no explanation). (Severity: 5) > # Variable, subroutine, and package names have to be in CamelCase at > line 26, column 5. (no explanation). (Severity: 5) > # Variable, subroutine, and package names have to be in CamelCase at > line 27, column 5. (no explanation). (Severity: 5) > # Variable, subroutine, and package names have to be in CamelCase at > line 28, column 5. (no explanation). (Severity: 5) > # Variable, subroutine, and package names have to be in CamelCase at > line 29, column 5. (no explanation). (Severity: 5) > # Variable, subroutine, and package names have to be in CamelCase at > line 30, column 5. (no explanation). (Severity: 5) > # Variable, subroutine, and package names have to be in CamelCase at > line 30, column 31. (no explanation). (Severity: 5) > # Variable, subroutine, and package names have to be in CamelCase at > line 31, column 5. (no explanation). (Severity: 5) > # Variable, subroutine, and package names have to be in CamelCase at > line 31, column 32. (no explanation). (Severity: 5) > # Perlsecret risk. Venus at line 33, column 3. Perlsecret > detected: %s. (Severity: 5) > ...
ile this test failure is indeed an issue that should be corrected, please don't allow pod, critic, coverage or kwalitee tests to run for normal user installs, as they make the installation fail unnecessarily when newer versions of the tester module introduces errors that you cannot anticipate. Also spelling tests are dependent on what dictionaries are installed locally, and critic tests use all plugins that are installed, neither of which can be predicted in advance. Either move these tests to xt/, or guard them with: plan skip_all => "These tests are for authors only!" unless $ENV{AUTHOR_TESTING} or $ENV{RELEASE_TESTING};
  Thu Sep 29 15:52:46 2016 The RT System itself - Status changed from 'new' to 'open'
  Thu Sep 29 15:53:30 2016 ether [...] cpan.org - Correspondence added
On 2016-09-29 12:52:46, ETHER wrote: Show quoted text
> ile this test failure...
Sorry, I dropped the leading "Wh" there :)