On 2016-09-29 10:51:43, SREZIC wrote:
Show quoted text> Tests fail if Test::Perl::Critic is installed --- maybe due to wrong
> usage?
>
> You tried to run a test without a plan! Gotta have a plan. at
> /opt/perl-5.25.5/lib/site_perl/5.25.5/Test/Perl/Critic.pm line 71.
> Can't locate object method "done_testing" via package "Test::Builder"
> at /opt/perl-5.25.5/lib/site_perl/5.25.5/Test/Perl/Critic.pm line 110.
> t/98_perlcritic.t ..
> Dubious, test returned 1 (wstat 256, 0x100)
> No subtests run
While this test failure is indeed an issue that should be corrected, please don't allow pod, critic, coverage or kwalitee tests to run for normal user installs, as they make the installation fail unnecessarily when newer versions of the tester module introduces errors that you cannot anticipate. Also spelling tests are dependent on what dictionaries are installed locally, and critic tests use all plugins that are installed, neither of which can be predicted in advance.
Either move these tests to xt/, or guard them with:
plan skip_all => "These tests are for authors only!" unless $ENV{AUTHOR_TESTING} or $ENV{RELEASE_TESTING};
