Bug #118114 for Git-Sub: Git::Sub (or System::Sub?) clobbers $

Wed Sep 28 04:13:25 2016 book [...] cpan.org - Ticket created

Subject:

Git::Sub (or System::Sub?) clobbers $_ in list context

The following tests expose the issue: $ perl -MGit::Sub -le '$_ = "canary"; $out = git::cat_file( qw( --batch-check --batch-all-objects ) ); print "\$_ = $_"' $_ = canary $ perl -MGit::Sub -le '$_ = "canary"; @out = git::cat_file( qw( --batch-check --batch-all-objects ) ); print "\$_ = $_"' $_ = I've just found this out, but haven't had time to investigate further. Tested with Git::Sub version 0.161810 and System::Sub version 0.150960.

Tue Oct 04 11:07:57 2016 dolmen [...] cpan.org - Correspondence added

Show quoted text

> Tested with Git::Sub version 0.161810 and System::Sub version
> 0.150960.

Thanks for this report.
The issue is in System::Sub. The generated wrapper subs use $_ without localizing it.

--
Olivier Mengué - http://perlresume.org/DOLMEN

Tue Oct 04 11:07:58 2016 The RT System itself - Status changed from 'new' to 'open'

Tue Oct 04 11:08:55 2016 dolmen [...] cpan.org - Taken

Tue Oct 04 11:08:55 2016 dolmen [...] cpan.org - Severity Normal added

Tue Nov 08 17:50:39 2016 dolmen [...] cpan.org - Correspondence added

The issue is fixed with System::Sub 0.162800.
I still have to make a new Git::Sub that requires it.

--
Olivier Mengué - http://perlresume.org/DOLMEN

Wed Mar 01 16:48:16 2017 dolmen [...] cpan.org - Correspondence added

Le 2016-11-08 23:50:39, DOLMEN a écrit :
Show quoted text

> The issue is fixed with System::Sub 0.162800.
> I still have to make a new Git::Sub that requires it.

Git::Sub has been released a few month ago.
https://metacpan.org/release/DOLMEN/Git-Sub-0.163320

--
Olivier Mengué - http://perlresume.org/DOLMEN

Wed Mar 01 16:48:16 2017 dolmen [...] cpan.org - Status changed from 'open' to 'resolved'

Wed Mar 01 16:48:16 2017 dolmen [...] cpan.org - Fixed in 0.163320 added

Bug #118114 for Git-Sub: Git::Sub (or System::Sub?) clobbers $_ in list context