Subject: | Negative repeat count does nothing at |
Date: | Wed, 21 Sep 2016 08:15:52 +0200 |
To: | bug-Term-VT102-Boundless [...] rt.cpan.org |
From: | h.huzen [...] belastingdienst.nl |
Using Term-VT102-Boundless on z/OS-Unix System Services, after a perl
upgrade from 5.8.7 to 5.22.0, use of Term-VT102-Boundless produced warning
lines:
' Negative repeat count does nothing at ... '
It turns out that in Term::VT102::Boundless.pm at two places in the
_process_text sub (line 35 and 48) the repeat operator ('x') is used where
the repeat count could be negative. I corrected that in my copy by changing
the preceding if statement:
<pre>
33
34 #ORIGINAL: if ( length($row) - $x ) {
35 if ( length($row) < $x ) {
36 $row .= " " x ( $x - length($row) );
37 }
38
39 substr ( $row, $x - 1, length $text) = $text;
40
41 my $newcols = length $row;
42 $self->{'cols'} = $newcols if $newcols > $self->{'cols'
};
43 }
44
45 for my $row_attrs ( $self->{'scra'}[$y] ) {
46 $row_attrs = '' unless defined $row_attrs;
47
48 #ORIGINAL: if ( ( length($row_attrs) / 2 ) - $x ) {
49 if ( ( length($row_attrs) / 2 ) < $x ) {
50 $row_attrs .= Term::VT102::DEFAULT_ATTR_PACKED
x ( $x - ( length($row_attrs) / 2 ) );
51 }
52
</pre>
Kind Regards
Harrie Huzen
------------------------------------------------------------------------
De Belastingdienst stelt e-mail niet open voor aanvragen, aangiften, bezwaarschriften, verzoeken, klachten, ingebrekestellingen en soortgelijke formele berichten.
Dit bericht is uitsluitend bestemd voor de geadresseerde. Het bericht kan vertrouwelijke informatie bevatten waarvoor de fiscale geheimhoudingsplicht geldt. Als u dit bericht per abuis hebt ontvangen, wordt u verzocht het te verwijderen en de afzender te informeren.
The Dutch Tax and Customs Administration does not accept filings, requests, appeals, complaints, notices of default or similar formal notices, sent by email.
This message is solely intended for the addressee. It may contain information that is confidential and legally privileged. If you are not the intended recipient please delete this message and notify the sender.