Bug #117919 for Devel-Command-NewF: perlcritic test may fail

Sat Sep 17 05:45:50 2016 SREZIC [...] cpan.org - Ticket created

Subject:

perlcritic test may fail

The perlcritic test fails if additional policies are installed (i.e. if Perl::Critic::OTRS is installed): # Failed test 'Test::Perl::Critic for "blib/lib/Devel/Command/NewF.pm"' # at /opt/perl-5.22.2/lib/site_perl/5.22.2/Test/Perl/Critic.pm line 104. # # Variable, subroutine, and package names have to be in CamelCase at line 12, column 1. (no explanation). (Severity: 5) # Variable, subroutine, and package names have to be in CamelCase at line 13, column 7. (no explanation). (Severity: 5) # Variable, subroutine, and package names have to be in CamelCase at line 14, column 8. (no explanation). (Severity: 5) # Variable, subroutine, and package names have to be in CamelCase at line 19, column 7. (no explanation). (Severity: 5) # Variable, subroutine, and package names have to be in CamelCase at line 19, column 19. (no explanation). (Severity: 5) # Variable, subroutine, and package names have to be in CamelCase at line 20, column 3. (no explanation). (Severity: 5) # Variable, subroutine, and package names have to be in CamelCase at line 23, column 6. (no explanation). (Severity: 5) # Variable, subroutine, and package names have to be in CamelCase at line 23, column 24. (no explanation). (Severity: 5) # Variable, subroutine, and package names have to be in CamelCase at line 24, column 8. (no explanation). (Severity: 5) # Variable, subroutine, and package names have to be in CamelCase at line 28, column 11. (no explanation). (Severity: 5) # Variable, subroutine, and package names have to be in CamelCase at line 34, column 7. (no explanation). (Severity: 5) # Variable, subroutine, and package names have to be in CamelCase at line 34, column 25. (no explanation). (Severity: 5) # Use of low precedence operators is not allowed at line 34, column 36. Replace low precedence operators with the high precedence substitutes. (Severity: 5) # Variable, subroutine, and package names have to be in CamelCase at line 49, column 1. (no explanation). (Severity: 5) # Variable, subroutine, and package names have to be in CamelCase at line 50, column 7. (no explanation). (Severity: 5) # Variable, subroutine, and package names have to be in CamelCase at line 51, column 6. (no explanation). (Severity: 5) # Variable, subroutine, and package names have to be in CamelCase at line 51, column 24. (no explanation). (Severity: 5) # Variable, subroutine, and package names have to be in CamelCase at line 53, column 7. (no explanation). (Severity: 5) # Variable, subroutine, and package names have to be in CamelCase at line 60, column 1. (no explanation). (Severity: 5) t/critic.t ........ Dubious, test returned 1 (wstat 256, 0x100) Failed 1/1 subtests

Sat Sep 17 17:24:02 2016 ether [...] cpan.org - Correspondence added

On 2016-09-17 02:45:50, SREZIC wrote: Show quoted text

> The perlcritic test fails if additional policies are installed (i.e. > if Perl::Critic::OTRS is installed): > > # Failed test 'Test::Perl::Critic for > "blib/lib/Devel/Command/NewF.pm"' > # at /opt/perl-5.22.2/lib/site_perl/5.22.2/Test/Perl/Critic.pm line > 104. > # > # Variable, subroutine, and package names have to be in CamelCase at > line 12, column 1. (no explanation). (Severity: 5) > # Variable, subroutine, and package names have to be in CamelCase at > line 13, column 7. (no explanation). (Severity: 5) > # Variable, subroutine, and package names have to be in CamelCase at > line 14, column 8. (no explanation). (Severity: 5) > # Variable, subroutine, and package names have to be in CamelCase at > line 19, column 7. (no explanation). (Severity: 5) > # Variable, subroutine, and package names have to be in CamelCase at > line 19, column 19. (no explanation). (Severity: 5) > # Variable, subroutine, and package names have to be in CamelCase at > line 20, column 3. (no explanation). (Severity: 5) > # Variable, subroutine, and package names have to be in CamelCase at > line 23, column 6. (no explanation). (Severity: 5) > # Variable, subroutine, and package names have to be in CamelCase at > line 23, column 24. (no explanation). (Severity: 5) > # Variable, subroutine, and package names have to be in CamelCase at > line 24, column 8. (no explanation). (Severity: 5) > # Variable, subroutine, and package names have to be in CamelCase at > line 28, column 11. (no explanation). (Severity: 5) > # Variable, subroutine, and package names have to be in CamelCase at > line 34, column 7. (no explanation). (Severity: 5) > # Variable, subroutine, and package names have to be in CamelCase at > line 34, column 25. (no explanation). (Severity: 5) > # Use of low precedence operators is not allowed at line 34, column > 36. Replace low precedence operators with the high precedence > substitutes. (Severity: 5) > # Variable, subroutine, and package names have to be in CamelCase at > line 49, column 1. (no explanation). (Severity: 5) > # Variable, subroutine, and package names have to be in CamelCase at > line 50, column 7. (no explanation). (Severity: 5) > # Variable, subroutine, and package names have to be in CamelCase at > line 51, column 6. (no explanation). (Severity: 5) > # Variable, subroutine, and package names have to be in CamelCase at > line 51, column 24. (no explanation). (Severity: 5) > # Variable, subroutine, and package names have to be in CamelCase at > line 53, column 7. (no explanation). (Severity: 5) > # Variable, subroutine, and package names have to be in CamelCase at > line 60, column 1. (no explanation). (Severity: 5) > t/critic.t ........ > Dubious, test returned 1 (wstat 256, 0x100) > Failed 1/1 subtests

While this test failure is indeed an issue that should be corrected, please don't allow pod, critic, coverage or kwalitee tests to run for normal user installs, as they make the installation fail unnecessarily when newer versions of the tester module introduces errors that you cannot anticipate. Also spelling tests are dependent on what dictionaries are installed locally, and critic tests use all plugins that are installed, neither of which can be predicted in advance. Either move these tests to xt/, or guard them with: plan skip_all => "These tests are for authors only!" unless $ENV{AUTHOR_TESTING} or $ENV{RELEASE_TESTING};

Sat Sep 17 17:24:03 2016 The RT System itself - Status changed from 'new' to 'open'

Fri May 15 14:03:49 2020 mcmahon [...] cpan.org - Taken