Bug #117891 for Plack-App-BeanstalkConsole: Download URL is terribly out of date

Fri Sep 16 14:31:00 2016 tsibley [...] cpan.org - Ticket created

Subject:

Download URL is terribly out of date

dist.ini should be: -url = http://github.com/downloads/ptrofimov/beanstalk_console/beanstalk_console.zip +url = https://github.com/ptrofimov/beanstalk_console/archive/master.zip The old endpoint is returning an ancient version of the source. The new link is what the source's README points to and is a snapshot of the project's master branch. One difference is that master.zip will need to have a leading directory component stripped when extracting, or paths within the share dir will need to be adjusted to prepend "beanstalk_console-master/". I set about preparing a patch for this, but ran into trouble and eventually gave up in frustration. First problem was installing the ginormous plugin bundle just so I could submit and test a tiny patch. Second was that once I did, "dzil build" reported this error: Module::Build::Tiny should not be used in distributions that are targeting perl 5.006! at /Users/trsibley/.perlbrew/libs/5.24@daily/lib/perl5/Dist/Zilla/PluginBundle/Author/ETHER.pm line 189, <GEN1> line 15. At that point, I gave up. ☹

Fri Sep 16 17:58:55 2016 ether [...] cpan.org - Taken

Fri Sep 16 17:59:50 2016 ether [...] cpan.org - Correspondence added

Show quoted text

> I set about preparing a patch for this, but ran into trouble and > eventually gave up in frustration. First problem was installing the > ginormous plugin bundle just so I could submit and test a tiny patch. > Second was that once I did, "dzil build" reported this error: > > Module::Build::Tiny should not be used in distributions that are > targeting perl 5.006! at > /Users/trsibley/.perlbrew/libs/5.24@daily/lib/perl5/Dist/Zilla/PluginBundle/Author/ETHER.pm > line 189, <GEN1> line 15. > > At that point, I gave up. ☹

No problem. Generally you shouldn't have to do anything with dzil to submit or test a patch, but this is a bit of an unusual distribution, and I haven't touched it in a while, so it's fallen behind the times with changes I've made to my bundle. I can take it from here. :)

Fri Sep 16 17:59:51 2016 The RT System itself - Status changed from 'new' to 'open'

Fri Sep 16 19:21:16 2016 ether [...] cpan.org - Correspondence added

On 2016-09-16 14:59:50, ETHER wrote: Show quoted text

>

> > I set about preparing a patch for this, but ran into trouble and > > eventually gave up in frustration. First problem was installing the > > ginormous plugin bundle just so I could submit and test a tiny patch. > > Second was that once I did, "dzil build" reported this error: > > > > Module::Build::Tiny should not be used in distributions that are > > targeting perl 5.006! at > > /Users/trsibley/.perlbrew/libs/5.24@daily/lib/perl5/Dist/Zilla/PluginBundle/Author/ETHER.pm > > line 189, <GEN1> line 15. > > > > At that point, I gave up. ☹

> > > No problem. Generally you shouldn't have to do anything with dzil to > submit or test a patch, but this is a bit of an unusual distribution, > and I haven't touched it in a while, so it's fallen behind the times > with changes I've made to my bundle. I can take it from here. :)

Out of curiosity, did you see the Makefile.PL in the repo, that was specifically added to make it easier for others to provide patches? :)

Fri Sep 16 20:37:43 2016 tsibley [...] cpan.org - Correspondence added

Subject:	Re: [rt.cpan.org #117891] Download URL is terribly out of date
Date:	Fri, 16 Sep 2016 17:37:10 -0700
To:	bug-Plack-App-BeanstalkConsole [...] rt.cpan.org
From:	Thomas Sibley <tsibley [...] cpan.org>

On 09/16/2016 04:21 PM, Karen Etheridge via RT wrote: Show quoted text

>> No problem. Generally you shouldn't have to do anything with dzil >> to submit or test a patch, but this is a bit of an unusual >> distribution, and I haven't touched it in a while, so it's fallen >> behind the times with changes I've made to my bundle. I can take it >> from here. :)

> > Out of curiosity, did you see the Makefile.PL in the repo, that was > specifically added to make it easier for others to provide patches? > :)

I saw the Makefile.PL, but there's also a Build.PL and Build.PL is what cpanm uses when it tries to install the dist out of the repo. Since my patch involved a configure/build time change, I kinda needed to be able to test that out, not just run tests out of the repo. It also wasn't clear to me from the contents of Makefile.PL and Build.PL and the related comment in dist.ini why the heck there were both for an MBT dist. I just wanted to submit a simple change but instead got clotheslined by build complexity. Since you're happy to make the change instead, it's no big deal really!

Sat Sep 17 00:22:23 2016 ether [...] cpan.org - Correspondence added

0.009 is released!

Sat Sep 17 00:22:28 2016 ether [...] cpan.org - Status changed from 'open' to 'resolved'

Sat Sep 17 17:05:15 2016 ether [...] cpan.org - Fixed in 0.009 added