On 2016-09-15 10:31:23, SREZIC wrote:
Show quoted text> If Test::Perl::Critic is installed:
>
> # Failed test 'Test::Perl::Critic for
> "blib/lib/Statistics/Test/WilcoxonRankSum.pm"'
> # at /usr/perl5.24.1-RC3p/lib/site_perl/5.24.1/Test/Perl/Critic.pm
> line 104.
> #
> # Perlsecret risk. Venus at line 235, column 5. Perlsecret
> detected: %s. (Severity: 5)
> t/perlcritic.t ................
> Dubious, test returned 1 (wstat 256, 0x100)
> Failed 1/1 subtests
>
>
> Depending on the installed Perl::Critic modules (i.e. if
> Perl::Critic::OTRS is installed) the failure list is much longer.
While this test failure is indeed an issue that should be corrected, please don't allow pod, critic, coverage or kwalitee tests to run for normal user installs, as they make the installation fail unnecessarily when newer versions of the tester module introduces errors that you cannot anticipate. Also spelling tests are dependent on what dictionaries are installed locally, and critic tests use all plugins that are installed, neither of which can be predicted in advance.
Either move these tests to xt/, or guard them with:
plan skip_all => "These tests are for authors only!" unless $ENV{AUTHOR_TESTING} or $ENV{RELEASE_TESTING};
