Bug #117825 for Timeout-Queue: perlcritic test may fail

Tue Sep 13 16:12:48 2016 SREZIC [...] cpan.org - Ticket created

Subject:

perlcritic test may fail

On some of my smoker systems tests fail: # Failed test 'Test::Perl::Critic for "blib/lib/Timeout/Queue.pm"' # at /usr/perl5.24.1-RC3p/lib/site_perl/5.24.1/Test/Perl/Critic.pm line 104. # # Perlsecret risk. Venus at line 100, column 9. Perlsecret detected: %s. (Severity: 5) # Perlsecret risk. Venus at line 215, column 24. Perlsecret detected: %s. (Severity: 5) # Perlsecret risk. Venus at line 241, column 9. Perlsecret detected: %s. (Severity: 5) t/critic.t ........... Dubious, test returned 1 (wstat 256, 0x100) See also http://analysis.cpantesters.org/solved?distv=Timeout-Queue-1.02#qr%3A%28Failed%20test\s%2B\S%2B.*%29 for an overview.

Tue Sep 13 17:19:32 2016 ether [...] cpan.org - Correspondence added

On 2016-09-13 13:12:48, SREZIC wrote: Show quoted text

> On some of my smoker systems tests fail: > > # Failed test 'Test::Perl::Critic for "blib/lib/Timeout/Queue.pm"' > # at /usr/perl5.24.1-RC3p/lib/site_perl/5.24.1/Test/Perl/Critic.pm > line 104. > # > # Perlsecret risk. Venus at line 100, column 9. Perlsecret > detected: %s. (Severity: 5) > # Perlsecret risk. Venus at line 215, column 24. Perlsecret > detected: %s. (Severity: 5) > # Perlsecret risk. Venus at line 241, column 9. Perlsecret > detected: %s. (Severity: 5) > t/critic.t ........... > Dubious, test returned 1 (wstat 256, 0x100) > > > See also http://analysis.cpantesters.org/solved?distv=Timeout-Queue- > 1.02#qr%3A%28Failed%20test\s%2B\S%2B.*%29 for an overview.

While this test failure is indeed an issue that should be corrected, please don't allow pod, critic, coverage or kwalitee tests to run for normal user installs, as they make the installation fail unnecessarily when newer versions of the tester module introduces errors that you cannot anticipate. Also spelling tests are dependent on what dictionaries are installed locally, and critic tests use all plugins that are installed, neither of which can be predicted in advance. Either move these tests to xt/, or guard them with: plan skip_all => "These tests are for authors only!" unless $ENV{AUTHOR_TESTING} or $ENV{RELEASE_TESTING};

Tue Sep 13 17:19:33 2016 The RT System itself - Status changed from 'new' to 'open'