Bug #117803 for Template-Provider-DBIC: perlcritic test may fail

Mon Sep 12 16:23:33 2016 SREZIC [...] cpan.org - Ticket created

Subject:

perlcritic test may fail

See http://analysis.cpantesters.org/reports_by_field?distv=Template-Provider-DBIC-0.02;field=qr%3A%28Failed%20test\s%2B\S%2B.*%29 for an overview of test reports exposing a problem with perlcritic. I think the fail happens only if both Test::Perl::Critic and Perl::Critic::OTRS is installed.

Mon Sep 12 16:42:46 2016 ether [...] cpan.org - Correspondence added

On 2016-09-12 13:23:33, SREZIC wrote: Show quoted text

> See http://analysis.cpantesters.org/reports_by_field?distv=Template- > Provider-DBIC-0.02;field=qr%3A%28Failed%20test\s%2B\S%2B.*%29 for an > overview of test reports exposing a problem with perlcritic. > > I think the fail happens only if both Test::Perl::Critic and > Perl::Critic::OTRS is installed.

While this test failure is indeed an issue that should be corrected, please don't allow pod, critic, coverage or kwalitee tests to run for normal user installs, as they make the installation fail unnecessarily when newer versions of the tester module introduces errors that you cannot anticipate. Also spelling tests are dependent on what dictionaries are installed locally, and critic tests use all plugins that are installed, neither of which can be predicted in advance. Either move these tests to xt/, or guard them with: plan skip_all => "These tests are for authors only!" unless $ENV{AUTHOR_TESTING} or $ENV{RELEASE_TESTING};

Mon Sep 12 16:42:47 2016 The RT System itself - Status changed from 'new' to 'open'