Bug #117791 for WebService-NotifyMyAndroid: perlcritic test may fail

Mon Sep 12 01:50:05 2016 SREZIC [...] cpan.org - Ticket created

Subject:

perlcritic test may fail

perlcritic test fails, probably only if Test::Perl::Critic and Perl::Critic::OTRS are installed: # Failed test 'Test::Perl::Critic for "blib/lib/WebService/NotifyMyAndroid.pm"' # at /opt/perl-5.25.4/lib/site_perl/5.25.4/Test/Perl/Critic.pm line 104. # # Variable, subroutine, and package names have to be in CamelCase at line 27, column 13. (no explanation). (Severity: 5) # Variable, subroutine, and package names have to be in CamelCase at line 49, column 24. (no explanation). (Severity: 5) # Variable, subroutine, and package names have to be in CamelCase at line 55, column 4. (no explanation). (Severity: 5) # Variable, subroutine, and package names have to be in CamelCase at line 71, column 1. (no explanation). (Severity: 5) # Variable, subroutine, and package names have to be in CamelCase at line 72, column 9. (no explanation). (Severity: 5) # Variable, subroutine, and package names have to be in CamelCase at line 72, column 16. (no explanation). (Severity: 5) # Variable, subroutine, and package names have to be in CamelCase at line 73, column 8. (no explanation). (Severity: 5) # Variable, subroutine, and package names have to be in CamelCase at line 73, column 28. (no explanation). (Severity: 5) # Variable, subroutine, and package names have to be in CamelCase at line 73, column 36. (no explanation). (Severity: 5) # Variable, subroutine, and package names have to be in CamelCase at line 74, column 12. (no explanation). (Severity: 5) # Variable, subroutine, and package names have to be in CamelCase at line 74, column 35. (no explanation). (Severity: 5) # Method invocation should use "()" at line 74, column 44. Use "->MethodName()" instead of "->MethodName". (Severity: 5) # Variable, subroutine, and package names have to be in CamelCase at line 77, column 4. (no explanation). (Severity: 5) # Use of bitwise operator at line 79, column 24. Use of bitwise operator "|". (Severity: 5) # Perlsecret risk. Venus at line 97, column 9. Perlsecret detected: %s. (Severity: 5) # Variable, subroutine, and package names have to be in CamelCase at line 111, column 1. (no explanation). (Severity: 5) # Variable, subroutine, and package names have to be in CamelCase at line 112, column 9. (no explanation). (Severity: 5) # Variable, subroutine, and package names have to be in CamelCase at line 112, column 16. (no explanation). (Severity: 5) # Variable, subroutine, and package names have to be in CamelCase at line 113, column 8. (no explanation). (Severity: 5) # Variable, subroutine, and package names have to be in CamelCase at line 113, column 28. (no explanation). (Severity: 5) # Variable, subroutine, and package names have to be in CamelCase at line 113, column 36. (no explanation). (Severity: 5) # Variable, subroutine, and package names have to be in CamelCase at line 114, column 12. (no explanation). (Severity: 5) # Variable, subroutine, and package names have to be in CamelCase at line 114, column 36. (no explanation). (Severity: 5) # Method invocation should use "()" at line 114, column 45. Use "->MethodName()" instead of "->MethodName". (Severity: 5) # Variable, subroutine, and package names have to be in CamelCase at line 119, column 1. (no explanation). (Severity: 5) # Variable, subroutine, and package names have to be in CamelCase at line 120, column 9. (no explanation). (Severity: 5) # Variable, subroutine, and package names have to be in CamelCase at line 120, column 21. (no explanation). (Severity: 5) # Variable, subroutine, and package names have to be in CamelCase at line 122, column 15. (no explanation). (Severity: 5) # Variable, subroutine, and package names have to be in CamelCase at line 123, column 20. (no explanation). (Severity: 5) # Variable, subroutine, and package names have to be in CamelCase at line 123, column 29. (no explanation). (Severity: 5) # Variable, subroutine, and package names have to be in CamelCase at line 124, column 29. (no explanation). (Severity: 5) # Use of low precedence operators is not allowed at line 124, column 36. Replace low precedence operators with the high precedence substitutes. (Severity: 5) # Variable, subroutine, and package names have to be in CamelCase at line 128, column 9. (no explanation). (Severity: 5) # Use of low precedence operators is not allowed at line 128, column 41. Replace low precedence operators with the high precedence substitutes. (Severity: 5) # Variable, subroutine, and package names have to be in CamelCase at line 130, column 13. (no explanation). (Severity: 5) t/perlcritic.t ............ Dubious, test returned 1 (wstat 256, 0x100) Failed 1/1 subtests

Mon Sep 12 12:22:44 2016 ether [...] cpan.org - Correspondence added

On 2016-09-11 22:50:05, SREZIC wrote: Show quoted text

> perlcritic test fails, probably only if Test::Perl::Critic and > Perl::Critic::OTRS are installed: > > # Failed test 'Test::Perl::Critic for > "blib/lib/WebService/NotifyMyAndroid.pm"' > # at /opt/perl-5.25.4/lib/site_perl/5.25.4/Test/Perl/Critic.pm line > 104. > # > # Variable, subroutine, and package names have to be in CamelCase at > line 27, column 13. (no explanation). (Severity: 5) > # Variable, subroutine, and package names have to be in CamelCase at > line 49, column 24. (no explanation). (Severity: 5) > # Variable, subroutine, and package names have to be in CamelCase at > line 55, column 4. (no explanation). (Severity: 5) > # Variable, subroutine, and package names have to be in CamelCase at > line 71, column 1. (no explanation). (Severity: 5) > # Variable, subroutine, and package names have to be in CamelCase at > line 72, column 9. (no explanation). (Severity: 5) > # Variable, subroutine, and package names have to be in CamelCase at > line 72, column 16. (no explanation). (Severity: 5) > # Variable, subroutine, and package names have to be in CamelCase at > line 73, column 8. (no explanation). (Severity: 5) > # Variable, subroutine, and package names have to be in CamelCase at > line 73, column 28. (no explanation). (Severity: 5) > # Variable, subroutine, and package names have to be in CamelCase at > line 73, column 36. (no explanation). (Severity: 5) > # Variable, subroutine, and package names have to be in CamelCase at > line 74, column 12. (no explanation). (Severity: 5) > # Variable, subroutine, and package names have to be in CamelCase at > line 74, column 35. (no explanation). (Severity: 5) > # Method invocation should use "()" at line 74, column 44. Use "-

> >MethodName()" instead of "->MethodName". (Severity: 5)

> # Variable, subroutine, and package names have to be in CamelCase at > line 77, column 4. (no explanation). (Severity: 5) > # Use of bitwise operator at line 79, column 24. Use of bitwise > operator "|". (Severity: 5) > # Perlsecret risk. Venus at line 97, column 9. Perlsecret > detected: %s. (Severity: 5) > # Variable, subroutine, and package names have to be in CamelCase at > line 111, column 1. (no explanation). (Severity: 5) > # Variable, subroutine, and package names have to be in CamelCase at > line 112, column 9. (no explanation). (Severity: 5) > # Variable, subroutine, and package names have to be in CamelCase at > line 112, column 16. (no explanation). (Severity: 5) > # Variable, subroutine, and package names have to be in CamelCase at > line 113, column 8. (no explanation). (Severity: 5) > # Variable, subroutine, and package names have to be in CamelCase at > line 113, column 28. (no explanation). (Severity: 5) > # Variable, subroutine, and package names have to be in CamelCase at > line 113, column 36. (no explanation). (Severity: 5) > # Variable, subroutine, and package names have to be in CamelCase at > line 114, column 12. (no explanation). (Severity: 5) > # Variable, subroutine, and package names have to be in CamelCase at > line 114, column 36. (no explanation). (Severity: 5) > # Method invocation should use "()" at line 114, column 45. Use "-

> >MethodName()" instead of "->MethodName". (Severity: 5)

> # Variable, subroutine, and package names have to be in CamelCase at > line 119, column 1. (no explanation). (Severity: 5) > # Variable, subroutine, and package names have to be in CamelCase at > line 120, column 9. (no explanation). (Severity: 5) > # Variable, subroutine, and package names have to be in CamelCase at > line 120, column 21. (no explanation). (Severity: 5) > # Variable, subroutine, and package names have to be in CamelCase at > line 122, column 15. (no explanation). (Severity: 5) > # Variable, subroutine, and package names have to be in CamelCase at > line 123, column 20. (no explanation). (Severity: 5) > # Variable, subroutine, and package names have to be in CamelCase at > line 123, column 29. (no explanation). (Severity: 5) > # Variable, subroutine, and package names have to be in CamelCase at > line 124, column 29. (no explanation). (Severity: 5) > # Use of low precedence operators is not allowed at line 124, column > 36. Replace low precedence operators with the high precedence > substitutes. (Severity: 5) > # Variable, subroutine, and package names have to be in CamelCase at > line 128, column 9. (no explanation). (Severity: 5) > # Use of low precedence operators is not allowed at line 128, column > 41. Replace low precedence operators with the high precedence > substitutes. (Severity: 5) > # Variable, subroutine, and package names have to be in CamelCase at > line 130, column 13. (no explanation). (Severity: 5) > t/perlcritic.t ............ > Dubious, test returned 1 (wstat 256, 0x100) > Failed 1/1 subtests

While this test failure is indeed an issue that should be corrected, please don't allow pod, critic, coverage or kwalitee tests to run for normal user installs, as they make the installation fail unnecessarily when newer versions of the tester module introduces errors that you cannot anticipate. Also spelling tests are dependent on what dictionaries are installed locally, and critic tests use all plugins that are installed, neither of which can be predicted in advance. Either move these tests to xt/, or guard them with: plan skip_all => "These tests are for authors only!" unless $ENV{AUTHOR_TESTING} or $ENV{RELEASE_TESTING};

Mon Sep 12 12:22:44 2016 The RT System itself - Status changed from 'new' to 'open'