Skip Menu |

This queue is for tickets about the Plack-Middleware-DoCoMoGUID CPAN distribution.

Report information
The Basics
Id: 117772
Status: open
Priority: 0/
Queue: Plack-Middleware-DoCoMoGUID
People
Owner: Nobody in particular
Requestors: SREZIC [...] cpan.org
Cc:
AdminCc:
Bug Information
Severity: (no value)
Broken in: 0.06
Fixed in: (no value)

History Show all quoted text
  Sun Sep 11 03:06:58 2016 SREZIC [...] cpan.org - Ticket created
Subject: perlcritic test may fail
The perlcritic test may fail, probably only if Perl::Critic::OTRS is installed: # Failed test 'Test::Perl::Critic for "lib/Plack/Middleware/DoCoMoGUID.pm"' # at /opt/perl-5.24.1-RC3/lib/site_perl/5.24.1/Test/Perl/Critic.pm line 104. # # Variable, subroutine, and package names have to be in CamelCase at line 12, column 1. (no explanation). (Severity: 5) # Variable, subroutine, and package names have to be in CamelCase at line 13, column 9. (no explanation). (Severity: 5) # Variable, subroutine, and package names have to be in CamelCase at line 13, column 16. (no explanation). (Severity: 5) # Variable, subroutine, and package names have to be in CamelCase at line 15, column 8. (no explanation). (Severity: 5) # Variable, subroutine, and package names have to be in CamelCase at line 16, column 10. (no explanation). (Severity: 5) # Variable, subroutine, and package names have to be in CamelCase at line 17, column 9. (no explanation). (Severity: 5) # Variable, subroutine, and package names have to be in CamelCase at line 17, column 27. (no explanation). (Severity: 5) # Variable, subroutine, and package names have to be in CamelCase at line 19, column 8. (no explanation). (Severity: 5) # Variable, subroutine, and package names have to be in CamelCase at line 19, column 68. (no explanation). (Severity: 5) # Method invocation should use "()" at line 19, column 73. Use "->MethodName()" instead of "->MethodName". (Severity: 5) # Variable, subroutine, and package names have to be in CamelCase at line 19, column 80. (no explanation). (Severity: 5) # Variable, subroutine, and package names have to be in CamelCase at line 20, column 5. (no explanation). (Severity: 5) # Variable, subroutine, and package names have to be in CamelCase at line 20, column 64. (no explanation). (Severity: 5) # Variable, subroutine, and package names have to be in CamelCase at line 20, column 70. (no explanation). (Severity: 5) # Variable, subroutine, and package names have to be in CamelCase at line 21, column 5. (no explanation). (Severity: 5) # Variable, subroutine, and package names have to be in CamelCase at line 21, column 60. (no explanation). (Severity: 5) # Variable, subroutine, and package names have to be in CamelCase at line 21, column 66. (no explanation). (Severity: 5) # Variable, subroutine, and package names have to be in CamelCase at line 22, column 12. (no explanation). (Severity: 5) # Variable, subroutine, and package names have to be in CamelCase at line 22, column 19. (no explanation). (Severity: 5) (etc.)
  Mon Sep 12 12:22:33 2016 ether [...] cpan.org - Correspondence added
On 2016-09-11 00:06:58, SREZIC wrote: Show quoted text
> The perlcritic test may fail, probably only if Perl::Critic::OTRS is > installed: > > # Failed test 'Test::Perl::Critic for > "lib/Plack/Middleware/DoCoMoGUID.pm"' > # at /opt/perl-5.24.1-RC3/lib/site_perl/5.24.1/Test/Perl/Critic.pm > line 104. > # > # Variable, subroutine, and package names have to be in CamelCase at > line 12, column 1. (no explanation). (Severity: 5) > # Variable, subroutine, and package names have to be in CamelCase at > line 13, column 9. (no explanation). (Severity: 5) > # Variable, subroutine, and package names have to be in CamelCase at > line 13, column 16. (no explanation). (Severity: 5) > # Variable, subroutine, and package names have to be in CamelCase at > line 15, column 8. (no explanation). (Severity: 5) > # Variable, subroutine, and package names have to be in CamelCase at > line 16, column 10. (no explanation). (Severity: 5) > # Variable, subroutine, and package names have to be in CamelCase at > line 17, column 9. (no explanation). (Severity: 5) > # Variable, subroutine, and package names have to be in CamelCase at > line 17, column 27. (no explanation). (Severity: 5) > # Variable, subroutine, and package names have to be in CamelCase at > line 19, column 8. (no explanation). (Severity: 5) > # Variable, subroutine, and package names have to be in CamelCase at > line 19, column 68. (no explanation). (Severity: 5) > # Method invocation should use "()" at line 19, column 73. Use "-
> >MethodName()" instead of "->MethodName". (Severity: 5)
> # Variable, subroutine, and package names have to be in CamelCase at > line 19, column 80. (no explanation). (Severity: 5) > # Variable, subroutine, and package names have to be in CamelCase at > line 20, column 5. (no explanation). (Severity: 5) > # Variable, subroutine, and package names have to be in CamelCase at > line 20, column 64. (no explanation). (Severity: 5) > # Variable, subroutine, and package names have to be in CamelCase at > line 20, column 70. (no explanation). (Severity: 5) > # Variable, subroutine, and package names have to be in CamelCase at > line 21, column 5. (no explanation). (Severity: 5) > # Variable, subroutine, and package names have to be in CamelCase at > line 21, column 60. (no explanation). (Severity: 5) > # Variable, subroutine, and package names have to be in CamelCase at > line 21, column 66. (no explanation). (Severity: 5) > # Variable, subroutine, and package names have to be in CamelCase at > line 22, column 12. (no explanation). (Severity: 5) > # Variable, subroutine, and package names have to be in CamelCase at > line 22, column 19. (no explanation). (Severity: 5) > (etc.)
While this test failure is indeed an issue that should be corrected, please don't allow pod, critic, coverage or kwalitee tests to run for normal user installs, as they make the installation fail unnecessarily when newer versions of the tester module introduces errors that you cannot anticipate. Also spelling tests are dependent on what dictionaries are installed locally, and critic tests use all plugins that are installed, neither of which can be predicted in advance. Either move these tests to xt/, or guard them with: plan skip_all => "These tests are for authors only!" unless $ENV{AUTHOR_TESTING} or $ENV{RELEASE_TESTING};
  Mon Sep 12 12:22:33 2016 The RT System itself - Status changed from 'new' to 'open'