Skip Menu |

This queue is for tickets about the Tk-ACH CPAN distribution.

Report information
The Basics
Id: 117714
Status: resolved
Priority: 0/
Queue: Tk-ACH

People
Owner: ASB [...] cpan.org
Requestors: SREZIC [...] cpan.org
Cc:
AdminCc:

Bug Information
Severity: (no value)
Broken in: 0.04
Fixed in: 0.08



Subject: Tests don't check for a working $DISPLAY
If a system does not have a running X11 server (often seen on CPAN Testers systems), then the test suite fails: PERL_DL_NONLAZY=1 "/usr/perl5.22.2p/bin/perl5.22.2" "-MExtUtils::Command::MM" "-MTest::Harness" "-e" "undef *Test::Harness::Switches; test_harness(0, 'blib/lib', 'blib/arch')" t/*.t # Test 2 got: "couldn't connect to display \":0\" at /usr/perl5.22.2p/lib/site_perl/5.22.2/amd64-freebsd/Tk/MainWindow.pm line 53.\nTk::MainWindow->new() at t/basic.t line 40.\n" (t/basic.t at line 41) # Expected: "" (can't create MainWindow) # t/basic.t line 41 is: ok($@, "", "can't create MainWindow"); # Test 3 got: "" (t/basic.t at line 42) # Expected: "1" (MainWindow creation failed) # t/basic.t line 42 is: ok(Tk::Exists($mw), 1, "MainWindow creation failed"); # Test 5 got: "Can't call method \"Entry\" on an undefined value at t/basic.t line 57.\n" (t/basic.t at line 58) # Expected: "" (can't create Entry widget) # t/basic.t line 58 is: ok($@, "", "can't create $class widget"); # Test 13 got: "Can't call method \"FileEntry\" on an undefined value at t/basic.t line 57.\n" (t/basic.t at line 58 fail #2) ... Probably the tests should just skip if the MainWindow cannot be created.
The tests were removed. Thank you for reporting the issues! Am Fr 09. Sep 2016, 16:47:32, SREZIC schrieb: Show quoted text
> If a system does not have a running X11 server (often seen on CPAN > Testers systems), then the test suite fails: > > PERL_DL_NONLAZY=1 "/usr/perl5.22.2p/bin/perl5.22.2" "- > MExtUtils::Command::MM" "-MTest::Harness" "-e" "undef > *Test::Harness::Switches; test_harness(0, 'blib/lib', 'blib/arch')" > t/*.t > # Test 2 got: "couldn't connect to display \":0\" at > /usr/perl5.22.2p/lib/site_perl/5.22.2/amd64-freebsd/Tk/MainWindow.pm > line 53.\nTk::MainWindow->new() at t/basic.t line 40.\n" (t/basic.t at > line 41) > # Expected: "" (can't create MainWindow) > # t/basic.t line 41 is: ok($@, "", "can't create MainWindow"); > # Test 3 got: "" (t/basic.t at line 42) > # Expected: "1" (MainWindow creation failed) > # t/basic.t line 42 is: ok(Tk::Exists($mw), 1, "MainWindow creation > failed"); > # Test 5 got: "Can't call method \"Entry\" on an undefined value at > t/basic.t line 57.\n" (t/basic.t at line 58) > # Expected: "" (can't create Entry widget) > # t/basic.t line 58 is: ok($@, "", "can't create $class widget"); > # Test 13 got: "Can't call method \"FileEntry\" on an undefined value > at t/basic.t line 57.\n" (t/basic.t at line 58 fail #2) > ... > > > Probably the tests should just skip if the MainWindow cannot be > created.