Bug #117686 for SMS-Send-AT-SmsAt: perlcritic test may fail

Fri Sep 09 02:07:20 2016 SREZIC [...] cpan.org - Ticket created

Subject:

perlcritic test may fail

On some of my smoker systems: # Failed test 'Test::Perl::Critic for "blib/lib/SMS/Send/AT/SmsAt.pm"' # at /usr/perl5.24.0p/lib/site_perl/5.24.0/Test/Perl/Critic.pm line 104. # # Variable, subroutine, and package names have to be in CamelCase at line 16, column 8. (no explanation). (Severity: 5) # Variable, subroutine, and package names have to be in CamelCase at line 17, column 8. (no explanation). (Severity: 5) # Variable, subroutine, and package names have to be in CamelCase at line 17, column 21. (no explanation). (Severity: 5) # Variable, subroutine, and package names have to be in CamelCase at line 17, column 31. (no explanation). (Severity: 5) # Variable, subroutine, and package names have to be in CamelCase at line 18, column 8. (no explanation). (Severity: 5) # Variable, subroutine, and package names have to be in CamelCase at line 20, column 5. (no explanation). (Severity: 5) # Use of low precedence operators is not allowed at line 20, column 20. Replace low precedence operators with the high precedence substitutes. (Severity: 5) (etc.)

Fri Sep 09 04:17:00 2016 nine [...] detonation.org - Correspondence added

Fixed in the just published version 0.0.5. Turns out I had the patch lying around for a couple years already and just had to make a new release :) Thanks for the report!

Fri Sep 09 04:17:00 2016 The RT System itself - Status changed from 'new' to 'open'

Fri Sep 09 04:17:00 2016 nine [...] detonation.org - Status changed from 'open' to 'resolved'

Fri Sep 09 16:28:48 2016 ether [...] cpan.org - Correspondence added

On 2016-09-08 23:07:20, SREZIC wrote: Show quoted text

> On some of my smoker systems: > > # Failed test 'Test::Perl::Critic for > "blib/lib/SMS/Send/AT/SmsAt.pm"' > # at /usr/perl5.24.0p/lib/site_perl/5.24.0/Test/Perl/Critic.pm line > 104. > # > # Variable, subroutine, and package names have to be in CamelCase at > line 16, column 8. (no explanation). (Severity: 5) > # Variable, subroutine, and package names have to be in CamelCase at > line 17, column 8. (no explanation). (Severity: 5) > # Variable, subroutine, and package names have to be in CamelCase at > line 17, column 21. (no explanation). (Severity: 5) > # Variable, subroutine, and package names have to be in CamelCase at > line 17, column 31. (no explanation). (Severity: 5) > # Variable, subroutine, and package names have to be in CamelCase at > line 18, column 8. (no explanation). (Severity: 5) > # Variable, subroutine, and package names have to be in CamelCase at > line 20, column 5. (no explanation). (Severity: 5) > # Use of low precedence operators is not allowed at line 20, column > 20. Replace low precedence operators with the high precedence > substitutes. (Severity: 5) > (etc.)

While this test failure is indeed an issue that should be corrected, please don't allow pod, critic, coverage or kwalitee tests to run for normal user installs, as they make the installation fail unnecessarily when newer versions of the tester module introduces errors that you cannot anticipate. Also spelling tests are dependent on what dictionaries are installed locally, and critic tests use all plugins that are installed, neither of which can be predicted in advance. Either move these tests to xt/, or guard them with: plan skip_all => "These tests are for authors only!" unless $ENV{AUTHOR_TESTING} or $ENV{RELEASE_TESTING};