Bug #117658 for DBIx-Class-DigestColumns-Lite: perlcritic test may fail

Thu Sep 08 14:46:39 2016 SREZIC [...] cpan.org - Ticket created

Subject:

perlcritic test may fail

See http://analysis.cpantesters.org/reports_by_field?distv=DBIx-Class-DigestColumns-Lite-0.03;field=fail%3At%2Fperlcritic.t for some example reports. On my smoker machines the fail log starts like this: # Failed test 'Test::Perl::Critic for "blib/lib/DBIx/Class/DigestColumns/Lite.pm"' # at /opt/perl-5.25.4/lib/site_perl/5.25.4/Test/Perl/Critic.pm line 104. # # Variable, subroutine, and package names have to be in CamelCase at line 12, column 1. (no explanation). (Severity: 5) # Variable, subroutine, and package names have to be in CamelCase at line 13, column 9. (no explanation). (Severity: 5) # Variable, subroutine, and package names have to be in CamelCase at line 13, column 16. (no explanation). (Severity: 5) # Variable, subroutine, and package names have to be in CamelCase at line 14, column 36. (no explanation). (Severity: 5) # Variable, subroutine, and package names have to be in CamelCase at line 14, column 51. (no explanation). (Severity: 5) # Method invocation should use "()" at line 14, column 56. Use "->MethodName()" instead of "->MethodName". (Severity: 5)

Thu Sep 08 19:46:25 2016 ether [...] cpan.org - Correspondence added

On 2016-09-08 11:46:39, SREZIC wrote: Show quoted text

> See http://analysis.cpantesters.org/reports_by_field?distv=DBIx-Class- > DigestColumns-Lite-0.03;field=fail%3At%2Fperlcritic.t for some example > reports. > > On my smoker machines the fail log starts like this: > > # Failed test 'Test::Perl::Critic for > "blib/lib/DBIx/Class/DigestColumns/Lite.pm"' > # at /opt/perl-5.25.4/lib/site_perl/5.25.4/Test/Perl/Critic.pm line > 104. > # > # Variable, subroutine, and package names have to be in CamelCase at > line 12, column 1. (no explanation). (Severity: 5) > # Variable, subroutine, and package names have to be in CamelCase at > line 13, column 9. (no explanation). (Severity: 5) > # Variable, subroutine, and package names have to be in CamelCase at > line 13, column 16. (no explanation). (Severity: 5) > # Variable, subroutine, and package names have to be in CamelCase at > line 14, column 36. (no explanation). (Severity: 5) > # Variable, subroutine, and package names have to be in CamelCase at > line 14, column 51. (no explanation). (Severity: 5) > # Method invocation should use "()" at line 14, column 56. Use "-

> >MethodName()" instead of "->MethodName". (Severity: 5)

While this test failure is indeed an issue that should be corrected, please don't allow pod, critic, coverage or kwalitee tests to run for normal user installs, as they make the installation fail unnecessarily when newer versions of the tester module introduces errors that you cannot anticipate. Also spelling tests are dependent on what dictionaries are installed locally, and critic tests use all plugins that are installed, neither of which can be predicted in advance. Either move these tests to xt/, or guard them with: plan skip_all => "These tests are for authors only!" unless $ENV{AUTHOR_TESTING} or $ENV{RELEASE_TESTING};

Thu Sep 08 19:46:25 2016 The RT System itself - Status changed from 'new' to 'open'