Skip Menu |

This queue is for tickets about the File-Path CPAN distribution.

Report information
The Basics
Id: 117620
Status: resolved
Priority: 0/
Queue: File-Path
People
Owner: jkeenan [...] cpan.org
Requestors: dom [...] cpan.org
Cc:
AdminCc:
Bug Information
Severity: (no value)
Broken in: 2.12
Fixed in: (no value)

History Show all quoted text
  Thu Sep 08 05:21:21 2016 dom [...] cpan.org - Ticket created
Subject: [PATCH] Don't hardcode ENOENT
The attached patch, provided by Pino Toscano of the Debian project, fixes a test failure on GNU/Hurd because on that platform, ENOENT is not 2. This fixes a regression between 2.11 and 2.12.
Subject: file-path-errno.diff
--- a/t/Path.t +++ b/t/Path.t @@ -8,6 +8,7 @@ use Config; use Fcntl ':mode'; use lib 't/'; use FilePathTest; +use Errno qw(:POSIX); BEGIN { use_ok('Cwd'); @@ -656,7 +657,7 @@ is( { my ($x, $message, $object, $expect, $rv, $arg, $error); my ($k, $v, $second_error, $third_error); - local $! = 2; + local $! = ENOENT; $x = $!; $message = 'message in a bottle';
  Thu Sep 08 08:36:15 2016 jkeenan [...] cpan.org - Correspondence added
On Thu Sep 08 05:21:21 2016, DOM wrote: Show quoted text
> The attached patch, provided by Pino Toscano of the Debian project, > fixes a test failure on GNU/Hurd because on that platform, ENOENT is > not 2. This fixes a regression between 2.11 and 2.12.
Is there a Debian bug ticket or mailing list thread that we can reference for this? Thank you very much. Jim Keenan
  Thu Sep 08 08:36:16 2016 The RT System itself - Status changed from 'new' to 'open'
  Thu Sep 08 08:40:33 2016 dom [...] earth.li - Correspondence added
Subject: Re: [rt.cpan.org #117620] [PATCH] Don't hardcode ENOENT
Date: Thu, 8 Sep 2016 13:40:19 +0100
To: James E Keenan via RT <bug-File-Path [...] rt.cpan.org>
From: Dominic Hargreaves <dom [...] earth.li>
On Thu, Sep 08, 2016 at 08:36:16AM -0400, James E Keenan via RT wrote: Show quoted text
> <URL: https://rt.cpan.org/Ticket/Display.html?id=117620 > > > On Thu Sep 08 05:21:21 2016, DOM wrote:
> > The attached patch, provided by Pino Toscano of the Debian project, > > fixes a test failure on GNU/Hurd because on that platform, ENOENT is > > not 2. This fixes a regression between 2.11 and 2.12.
> > > Is there a Debian bug ticket or mailing list thread that we can reference for this?
There is a passing reference in https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=836892 but that's mainly about another issue. Dominic.
  Tue Sep 13 22:30:09 2016 jkeenan [...] cpan.org - Correspondence added
On Thu Sep 08 05:21:21 2016, DOM wrote: Show quoted text
> The attached patch, provided by Pino Toscano of the Debian project, > fixes a test failure on GNU/Hurd because on that platform, ENOENT is > not 2. This fixes a regression between 2.11 and 2.12.
Reference: https://github.com/rpcme/File-Path/pull/36
  Wed Mar 08 16:09:51 2017 jkeenan [...] cpan.org - Correspondence added
On Tue Sep 13 22:30:09 2016, JKEENAN wrote: Show quoted text
> On Thu Sep 08 05:21:21 2016, DOM wrote:
> > The attached patch, provided by Pino Toscano of the Debian project, > > fixes a test failure on GNU/Hurd because on that platform, ENOENT is > > not 2. This fixes a regression between 2.11 and 2.12.
> > > Reference: https://github.com/rpcme/File-Path/pull/36
Merged into rpcme/master Sep 16 2016, but awaits CPAN release.
  Wed May 31 20:47:34 2017 jkeenan [...] cpan.org - Correspondence added
On Wed Mar 08 16:09:51 2017, JKEENAN wrote: Show quoted text
> On Tue Sep 13 22:30:09 2016, JKEENAN wrote:
> > On Thu Sep 08 05:21:21 2016, DOM wrote:
> > > The attached patch, provided by Pino Toscano of the Debian project, > > > fixes a test failure on GNU/Hurd because on that platform, ENOENT is > > > not 2. This fixes a regression between 2.11 and 2.12.
> > > > > > Reference: https://github.com/rpcme/File-Path/pull/36
> > Merged into rpcme/master Sep 16 2016, but awaits CPAN release.
This change has been released to CPAN as part of the release of File-Path 2.13 today. Marking ticket Resolved. Thank you very much. Jim Keenan
  Wed May 31 20:47:40 2017 jkeenan [...] cpan.org - Status changed from 'open' to 'resolved'
  Wed May 31 20:47:41 2017 jkeenan [...] cpan.org - Taken