Skip Menu |

This queue is for tickets about the Regexp-Ethiopic CPAN distribution.

Report information
The Basics
Id: 117602
Status: open
Priority: 0/
Queue: Regexp-Ethiopic

People
Owner: Nobody in particular
Requestors: SREZIC [...] cpan.org
Cc:
AdminCc:

Bug Information
Severity: (no value)
Broken in: 0.15
Fixed in: (no value)



Subject: The encoding pragma is no longer supported
Tests fail with bleadperl (e.g. perl 5.25.4): PERL_DL_NONLAZY=1 "/bbbike/perl-5.25.4/bin/perl5.25.4" "-MExtUtils::Command::MM" "-MTest::Harness" "-e" "undef *Test::Harness::Switches; test_harness(0, 'blib/lib', 'blib/arch')" t/*.t The encoding pragma is no longer supported at t/01re.t line 10. BEGIN failed--compilation aborted at t/01re.t line 10. t/01re.t .. Dubious, test returned 255 (wstat 65280, 0xff00) No subtests run
On Wed Sep 07 16:52:41 2016, SREZIC wrote: Show quoted text
> Tests fail with bleadperl (e.g. perl 5.25.4): > > PERL_DL_NONLAZY=1 "/bbbike/perl-5.25.4/bin/perl5.25.4" "- > MExtUtils::Command::MM" "-MTest::Harness" "-e" "undef > *Test::Harness::Switches; test_harness(0, 'blib/lib', 'blib/arch')" > t/*.t > The encoding pragma is no longer supported at t/01re.t line 10. > BEGIN failed--compilation aborted at t/01re.t line 10. > t/01re.t .. > Dubious, test returned 255 (wstat 65280, 0xff00) > No subtests run
This patch gets the tests passing. The use of encoding.pm used to set the encoding of the standard handles, making the binmodes redundant. Without encoding.pm, those binmodes are no longer redundant, but need to be at BEGIN time.
Subject: open_bpLkElgh.txt
diff -rup Regexp-Ethiopic-0.15-0-orig/t/01re.t Regexp-Ethiopic-0.15-0/t/01re.t --- Regexp-Ethiopic-0.15-0-orig/t/01re.t 2016-09-10 22:49:56.000000000 -0700 +++ Regexp-Ethiopic-0.15-0/t/01re.t 2016-09-10 22:50:05.000000000 -0700 @@ -3,11 +3,12 @@ ######################### We start with some black magic to print on failure. -binmode(STDOUT, ":utf8"); -binmode(STDERR, ":utf8"); +BEGIN { + binmode(STDOUT, ":utf8"); + binmode(STDERR, ":utf8"); +} use strict; use utf8; -use encoding 'utf8'; use Test::More qw(no_plan); use Regexp::Ethiopic::Amharic 'overload';