Skip Menu |

This queue is for tickets about the IO-EventMux-Socket-MsgHdr CPAN distribution.

Report information
The Basics
Id: 117564
Status: open
Priority: 0/
Queue: IO-EventMux-Socket-MsgHdr

People
Owner: Nobody in particular
Requestors: SREZIC [...] cpan.org
Cc:
AdminCc:

Bug Information
Severity: (no value)
Broken in: 0.02
Fixed in: (no value)



Subject: perlcritic test may fail
On some of my smoker machines the perlcritic fails like this: # # Variable, subroutine, and package names have to be in CamelCase at line 74, column 5. (no explanation). (Severity: 5) # Perlsecret risk. Venus at line 83, column 5. Perlsecret detected: %s. (Severity: 5) # Variable, subroutine, and package names have to be in CamelCase at line 102, column 8. (no explanation). (Severity: 5) # Variable, subroutine, and package names have to be in CamelCase at line 103, column 8. (no explanation). (Severity: 5) # Variable, subroutine, and package names have to be in CamelCase at line 107, column 11. (no explanation). (Severity: 5) # Variable, subroutine, and package names have to be in CamelCase at line 107, column 18. (no explanation). (Severity: 5) ... # Use of "require" is not allowed at line 269, column 1. Use Require() method of MainObject instead. (Severity: 5) ... # Perlsecret risk. Venus at line 288, column 18. Perlsecret detected: %s. (Severity: 5) ... # Use of low precedence operators is not allowed at line 313, column 8. Replace low precedence operators with the high precedence substitutes. (Severity: 5) ... # Method invocation should use "()" at line 342, column 58. Use "->MethodName()" instead of "->MethodName". (Severity: 5) ... # Variable, subroutine, and package names have to be in CamelCase at line 385, column 30. (no explanation). (Severity: 5) # Variable, subroutine, and package names have to be in CamelCase at line 386, column 39. (no explanation). (Severity: 5) # Variable, subroutine, and package names have to be in CamelCase at line 394, column 12. (no explanation). (Severity: 5) t/critic.t ... Dubious, test returned 1 (wstat 256, 0x100) Failed 1/1 subtests
On 2016-09-06 14:20:53, SREZIC wrote: Show quoted text
> On some of my smoker machines the perlcritic fails like this: > > # > # Variable, subroutine, and package names have to be in CamelCase at > line 74, column 5. (no explanation). (Severity: 5) > # Perlsecret risk. Venus at line 83, column 5. Perlsecret > detected: %s. (Severity: 5) > # Variable, subroutine, and package names have to be in CamelCase at > line 102, column 8. (no explanation). (Severity: 5) > # Variable, subroutine, and package names have to be in CamelCase at > line 103, column 8. (no explanation). (Severity: 5) > # Variable, subroutine, and package names have to be in CamelCase at > line 107, column 11. (no explanation). (Severity: 5) > # Variable, subroutine, and package names have to be in CamelCase at > line 107, column 18. (no explanation). (Severity: 5) > ... > # Use of "require" is not allowed at line 269, column 1. Use > Require() method of MainObject instead. (Severity: 5) > ... > # Perlsecret risk. Venus at line 288, column 18. Perlsecret > detected: %s. (Severity: 5) > ... > # Use of low precedence operators is not allowed at line 313, column > 8. Replace low precedence operators with the high precedence > substitutes. (Severity: 5) > ... > # Method invocation should use "()" at line 342, column 58. Use "-
> >MethodName()" instead of "->MethodName". (Severity: 5)
> ... > # Variable, subroutine, and package names have to be in CamelCase at > line 385, column 30. (no explanation). (Severity: 5) > # Variable, subroutine, and package names have to be in CamelCase at > line 386, column 39. (no explanation). (Severity: 5) > # Variable, subroutine, and package names have to be in CamelCase at > line 394, column 12. (no explanation). (Severity: 5) > t/critic.t ... > Dubious, test returned 1 (wstat 256, 0x100) > Failed 1/1 subtests
While this test failure is indeed an issue that should be corrected, please don't allow pod, critic, coverage or kwalitee tests to run for normal user installs, as they make the installation fail unnecessarily when newer versions of the tester module introduces errors that you cannot anticipate. Also spelling tests are dependent on what dictionaries are installed locally, and critic tests use all plugins that are installed, neither of which can be predicted in advance. Either move these tests to xt/, or guard them with: plan skip_all => "These tests are for authors only!" unless $ENV{AUTHOR_TESTING} or $ENV{RELEASE_TESTING};