Bug #117271 for DBIx-Class: libdbix-class-perl: FTBFS: Tests failures

Sun Aug 28 12:12:10 2016 gregoa [...] cpan.org - Ticket created

From:	gregoa [...] cpan.org
Subject:	libdbix-class-perl: FTBFS: Tests failures

We have the following bug reported to the Debian package of DBIx-Class (https://bugs.debian.org/835731): It doesn't seem to be a bug in the packaging, so you may want to take a look. Thanks! I also added some notes about when the test started failing and a pseudo-diff between an older successful build log and a newer one with the failure to the bug report which shows the differences in the dependencies. ------8<-----------8<-----------8<-----------8<-----------8<----- Source: libdbix-class-perl Version: 0.082840-1 Severity: serious Tags: stretch sid User: debian-qa@lists.debian.org Usertags: qa-ftbfs-20160828 qa-ftbfs Justification: FTBFS on amd64 Hi, During a rebuild of all packages in sid, your package failed to build on amd64. Relevant part (hopefully): Show quoted text

> ok 3 # skip Not checking for bless handling as performance is OK > 1..3 > # Auto checked 0 references for leaks - none detected > ok > t/zzzzzzz_sqlite_deadlock.t ......................... skipped: Skipping test on plain module install > > Test Summary Report > ------------------- > t/prefetch/grouped.t (Wstat: 65280 Tests: 31 Failed: 1) > Failed test: 28 > Non-zero exit status: 255 > Parse errors: No plan found in TAP output > Files=308, Tests=13370, 114 wallclock secs ( 2.17 usr 0.60 sys + 106.21 cusr 5.45 csys = 114.43 CPU) > Result: FAIL > Failed 1/308 test programs. 1/13370 subtests failed. > Makefile:1697: recipe for target 'test_dynamic' failed

The full build log is available from: http://people.debian.org/~lucas/logs/2016/08/28/libdbix-class-perl_0.082840-1_unstable.log A list of current common problems and possible solutions is available at http://wiki.debian.org/qa.debian.org/FTBFS . You're welcome to contribute! About the archive rebuild: The rebuild was done on EC2 VM instances from Amazon Web Services, using a clean, minimal and up-to-date chroot. Every failed build was retried once to eliminate random failures. ------8<-----------8<-----------8<-----------8<-----------8<----- Thanks for considering, gregor herrmann, Debian Perl Group

Mon Aug 29 03:20:19 2016 ribasushi [...] leporine.io - Correspondence added

Subject:	Re: [rt.cpan.org #117271] libdbix-class-perl: FTBFS: Tests failures
Date:	Mon, 29 Aug 2016 09:19:53 +0200
To:	bug-DBIx-Class [...] rt.cpan.org
From:	Peter Rabbitson <ribasushi [...] cpan.org>

On 08/28/2016 06:12 PM, gregor herrmann via RT wrote: Show quoted text

> > We have the following bug reported to the Debian package of > DBIx-Class (https://bugs.debian.org/835731): > > It doesn't seem to be a bug in the packaging, so you may want to take > a look. Thanks!

Yes, this is a bug in the test suite, tickled by the latest libsqlite in sid. Smaller reproduction is (5.16 is build against sid sqlite, 5.24 against the stock one that comes with DBD::SQlite): ~/devel/dbic$ perlbrew exec --with=5.16.2,5.24.0 perl -Ilib -It/lib -MDBICTest -e ' warn DBICTest->init_schema ->resultset("CD") ->search({ "tracks.cd" => { "!=", undef } }, { prefetch => "tracks", rows => 1 }) ->first ->id ' 5.16.2 ========== 2 at -e line 2, <> line 1. 5.24.0 ========== 1 at -e line 2, <> line 1. Given SQLite makes no guarantees as to the order of results without an explicit ORDER BY clause - this is my problem. I will address this in several days. Thanks for the report! Cheers

Mon Aug 29 03:20:20 2016 The RT System itself - Status changed from 'new' to 'open'

Mon Aug 29 12:58:25 2016 gregoa [...] debian.org - Correspondence added

Subject:	Re: [rt.cpan.org #117271] libdbix-class-perl: FTBFS: Tests failures
Date:	Mon, 29 Aug 2016 18:58:05 +0200
To:	Peter Rabbitson via RT <bug-DBIx-Class [...] rt.cpan.org>
From:	gregor herrmann <gregoa [...] debian.org>

On Mon, 29 Aug 2016 03:20:20 -0400, Peter Rabbitson via RT wrote: Show quoted text

> <URL: https://rt.cpan.org/Ticket/Display.html?id=117271 >

Show quoted text

> Yes, this is a bug in the test suite, tickled by the latest libsqlite in > sid.

Oh, sqlite. Nice catch. Show quoted text

> Given SQLite makes no guarantees as to the order of results without an > explicit ORDER BY clause - this is my problem. > I will address this in several days.

Thank you! Cheers, gregor -- .''`. Homepage https://info.comodo.priv.at/ - OpenPGP key 0xBB3A68018649AA06 : :' : Debian GNU/Linux user, admin, and developer - https://www.debian.org/ `. `' Member of VIBE!AT & SPI, fellow of the Free Software Foundation Europe `- NP: Bettina Wegner: Sie hat's gewusst

Download signature.asc
application/pgp-signature 931b

Message body not shown because it is not plain text.

Tue Sep 13 12:06:32 2016 ribasushi [...] leporine.io - Correspondence added

On Mon Aug 29 18:58:25 2016, gregoa@debian.org wrote: Show quoted text

> On Mon, 29 Aug 2016 03:20:20 -0400, Peter Rabbitson via RT wrote: > >

> > Given SQLite makes no guarantees as to the order of results without an > > explicit ORDER BY clause - this is my problem. > > I will address this in several days.

> > Thank you! >

Now addressed in https://github.com/dbsrgits/dbix-class/commit/adcc1df00, you should be able to easily cherry-pick it into the debian tree. Sorry for the delay. Cheers

Tue Sep 13 12:06:37 2016 ribasushi [...] leporine.io - Status changed from 'open' to 'patched'

Tue Sep 13 13:26:49 2016 gregoa [...] debian.org - Correspondence added

Subject:	Re: [rt.cpan.org #117271] libdbix-class-perl: FTBFS: Tests failures
Date:	Tue, 13 Sep 2016 19:26:20 +0200
To:	Peter Rabbitson via RT <bug-DBIx-Class [...] rt.cpan.org>
From:	gregor herrmann <gregoa [...] debian.org>

On Tue, 13 Sep 2016 12:06:37 -0400, Peter Rabbitson via RT wrote: Show quoted text

> <URL: https://rt.cpan.org/Ticket/Display.html?id=117271 >

Show quoted text

> Now addressed in > https://github.com/dbsrgits/dbix-class/commit/adcc1df00, you should > be able to easily cherry-pick it into the debian tree.

Excellent, thank you! Cheery-picked, built+uploaded. Cheers, gregor -- .''`. Homepage https://info.comodo.priv.at/ - OpenPGP key 0xBB3A68018649AA06 : :' : Debian GNU/Linux user, admin, and developer - https://www.debian.org/ `. `' Member of VIBE!AT & SPI, fellow of the Free Software Foundation Europe `- NP: Dido: Afraid to Sleep

Download signature.asc
application/pgp-signature 931b

Message body not shown because it is not plain text.

Wed Sep 14 04:23:08 2016 ribasushi [...] leporine.io - Correspondence added

On Tue Sep 13 19:26:49 2016, gregoa@debian.org wrote: Show quoted text

> > Cheery-picked, built+uploaded. >

A followup about a minor (non-affecting) issue: there seems to be a broken parser somewhere in your patch application process. The patch I pushed to the dbic tree has: Sha1: adcc1df0049e0093cb94c867bd2be8c9fe242a61 Author: Peter Rabbitson <ribasushi@cpan.org> 2016-09-13 17:15:48 Committer: Peter Rabbitson <ribasushi@cpan.org> 2016-09-13 17:34:02 Yet https://anonscm.debian.org/cgit/pkg-perl/packages/libdbix-class-perl.git/commit/?id=c7f237f72a1694e2c0a97177faad53528cee50cd lists it as ... +From adcc1df0049e0093cb94c867bd2be8c9fe242a61 Mon Sep 17 00:00:00 2001 ... Cheers

Wed Sep 14 04:51:27 2016 gregoa [...] debian.org - Correspondence added

Subject:	Re: [rt.cpan.org #117271] libdbix-class-perl: FTBFS: Tests failures
Date:	Wed, 14 Sep 2016 10:51:09 +0200
To:	Peter Rabbitson via RT <bug-DBIx-Class [...] rt.cpan.org>
From:	gregor herrmann <gregoa [...] debian.org>

On Wed, 14 Sep 2016 04:23:09 -0400, Peter Rabbitson via RT wrote: Show quoted text

> > Cheery-picked, built+uploaded.

Show quoted text

> A followup about a minor (non-affecting) issue: there seems to be a > broken parser somewhere in your patch application process.

Interesting finding ... Show quoted text

> The > patch I pushed to the dbic tree has: > > Sha1: adcc1df0049e0093cb94c867bd2be8c9fe242a61 > Author: Peter Rabbitson <ribasushi@cpan.org> 2016-09-13 17:15:48 > Committer: Peter Rabbitson <ribasushi@cpan.org> 2016-09-13 17:34:02 > > Yet https://anonscm.debian.org/cgit/pkg-perl/packages/libdbix-class-perl.git/commit/?id=c7f237f72a1694e2c0a97177faad53528cee50cd > lists it as > > ... > +From adcc1df0049e0093cb94c867bd2be8c9fe242a61 Mon Sep 17 00:00:00 2001 > ...

It's not the original commit because that one also contained changes to Changes (which we don't need and which don't apply), and it applied with an offset. So what I did was roughly: - git format-patch -1 adcc1df0049e0093cb94c867bd2be8c9fe242a61 - mkdir debian/patches - quilt import 0001-.... - either quilt push -f or $EDITOR debian/patches/0001-... + quilt push to ignore the changes in Changes - quilt refresh (because of the offset) - quilt pop - $EDITOR debian/patches/0001-... to add the bug numbers But yes, "Mon Sep 17 00:00:00 2001" is indeed rather interesting. Weird. Oh! I found something: https://github.com/dbsrgits/dbix-class/commit/adcc1df00.patch (which is probably github's git-format-patch equivalent) also has "From adcc1df0049e0093cb94c867bd2be8c9fe242a61 Mon Sep 17 00:00:00 2001" So I still don't know how this happens, but at least it's the same on github and my local git-format-patch :) Cheers, gregor -- .''`. Homepage https://info.comodo.priv.at/ - OpenPGP key 0xBB3A68018649AA06 : :' : Debian GNU/Linux user, admin, and developer - https://www.debian.org/ `. `' Member of VIBE!AT & SPI, fellow of the Free Software Foundation Europe `- BOFH excuse #99: SIMM crosstalk.

Mon Jan 29 04:22:55 2018 ribasushi [...] leporine.io - Fixed in 0.082841 added

Mon Jan 29 04:22:55 2018 ribasushi [...] leporine.io - Correspondence added

Now on CPAN: https://metacpan.org/release/RIBASUSHI/DBIx-Class-0.082841

Mon Jan 29 04:22:56 2018 ribasushi [...] leporine.io - Status changed from 'patched' to 'resolved'