Skip Menu |

This queue is for tickets about the IO-Compress-Brotli CPAN distribution.

Report information
The Basics
Id: 117269
Status: resolved
Priority: 0/
Queue: IO-Compress-Brotli
People
Owner: Nobody in particular
Requestors: SREZIC [...] cpan.org
Cc:
AdminCc:
Bug Information
Severity: (no value)
Broken in: 0.002
Fixed in: 0.002001

History Show all quoted text
  Sun Aug 28 04:51:15 2016 SREZIC [...] cpan.org - Ticket created
Subject: GNU make required on non-linux systems
On my freebsd smokers building fails: Output from '/usr/bin/make': cp lib/IO/Uncompress/Brotli.pm blib/lib/IO/Uncompress/Brotli.pm cp lib/IO/Compress/Brotli.pm blib/lib/IO/Compress/Brotli.pm cd brotli && CFLAGS=-fPIC make lib "Makefile", line 13: Missing dependency operator "Makefile", line 15: Need an operator make: fatal errors encountered -- cannot continue *** [brotli/libbrotli.a] Error code 1 The error indicates that the Makefile contains GNU make specific syntax and does not work with freebsd's default make. A possible fix here is to use "gmake" instead of "make", at least for freebsd and probably other *BSD systems (netbsd, openbsd).
  Sun Aug 28 05:24:29 2016 marius [...] ieval.ro - Correspondence added
Thanks for reporting this issue. Using gmake instead of $(MAKE) makes sense to me too. However, I'd also like to pass any flags/variable overrides given to [perl Makefile.PL] down to [brotli/Makefile]. Do you happen to know if any of $(MAKEOVERRIDES), $(MAKEFLAGS) and $(MFLAGS) exist in *BSD make, and if so which of them are most portable? (I'd guess $(MFLAGS) here, as it seems to be the oldest)
  Sun Aug 28 05:24:29 2016 The RT System itself - Status changed from 'new' to 'open'
  Sun Aug 28 05:32:40 2016 SREZIC [...] cpan.org - Correspondence added
On 2016-08-28 05:24:29, MGV wrote: Show quoted text
> Thanks for reporting this issue. > > Using gmake instead of $(MAKE) makes sense to me too. However, I'd > also like to pass any flags/variable overrides given to [perl > Makefile.PL] down to [brotli/Makefile]. Do you happen to know if any > of $(MAKEOVERRIDES), $(MAKEFLAGS) and $(MFLAGS) exist in *BSD make, > and if so which of them are most portable? (I'd guess $(MFLAGS) here, > as it seems to be the oldest)
https://www.freebsd.org/cgi/man.cgi?make%281%29 lists MAKEFLAGS. The manpage of the freebsd9 version also listed MFLAGS, but maybe it was removed or is not documented anymore.
  Fri Sep 09 03:01:11 2016 marius [...] ieval.ro - Correspondence added
Fixed in 0.002001. Now the Makefile looks for gmake and uses it found in PATH, otherwise it falls back to $(MAKE).
  Fri Sep 09 03:01:12 2016 marius [...] ieval.ro - Status changed from 'open' to 'resolved'
  Fri Sep 09 03:01:12 2016 marius [...] ieval.ro - Fixed in 0.002001 added