Bug #117218 for WWW-Google-PageRank: The encoding pragma is no longer supported

Thu Aug 25 16:44:11 2016 SREZIC [...] cpan.org - Ticket created

Subject:

The encoding pragma is no longer supported

t/utf8.t fails with perl 5.25.4 and later. See http://matrix.cpantesters.org/?dist=WWW-Google-PageRank%200.17 for an overview of test reports.

Thu Aug 25 16:51:59 2016 $_ = 'spro^^*%*^6ut# [...] &$%*c>#!^!#&!pan.org'; y/a-z.@//cd; print - Correspondence added

On Thu Aug 25 16:44:11 2016, SREZIC wrote: Show quoted text

> t/utf8.t fails with perl 5.25.4 and later. See > http://matrix.cpantesters.org/?dist=WWW-Google-PageRank%200.17 for an > overview of test reports.

I don’t understand the purpose of t/utf8.t (the failing test script). It is practically identical to t/local.t, but with ‘use encoding 'utf8';’ at the top. It seems its purpose is to make sure that encoding.pm does not accidentally break WWW::Google::PageRank. If that is its purpose it would be appropriate to skip it for newer perls. See the attachment.

Subject:

open_A8I0S4cC.txt

diff -rup WWW-Google-PageRank-0.17-0-orig/t/utf8.t WWW-Google-PageRank-0.17-0/t/utf8.t --- WWW-Google-PageRank-0.17-0-orig/t/utf8.t 2010-08-08 02:52:17.000000000 -0700 +++ WWW-Google-PageRank-0.17-0/t/utf8.t 2016-08-25 13:51:29.000000000 -0700 @@ -1,8 +1,8 @@ #!perl -w BEGIN { - if ($^V lt v5.8.0) { - print "1..0 # Skip perl 5.8.0 or newer required\n"; + if ($^V lt v5.8.0 || $^V gt v5.25.0) { + print "1..0 # Skip perl 5.8.0 to 5.24 required\n"; exit; } }

Thu Aug 25 16:51:59 2016 The RT System itself - Status changed from 'new' to 'open'

Fri Aug 26 04:06:39 2016 YKAR [...] cpan.org - Correspondence added

Show quoted text

> It seems its purpose is to make sure that encoding.pm does not > accidentally break WWW::Google::PageRank. If that is its purpose it > would be appropriate to skip it for newer perls. See the attachment.

Yes this test was added to make sure that use encoding won't break WWW::Google::PageRank (see rt #18913). Thank you for the patch, I applied it and uploaded 0.19 to CPAN.

Fri Aug 26 04:06:44 2016 YKAR [...] cpan.org - Status changed from 'open' to 'resolved'